Re: [PATCH 4/4] TTY: serial, move 68360 driver to staging

Greg KH
2011-08-31T19:41:51Z

On Wed, Aug 31, 2011 at 10:31:26PM +0300, Sasha Levin wrote:
> On Wed, 2011-08-31 at 21:24 +0200, Jiri Slaby wrote:
> > This driver has been broken at least since 2008. At that time,
> > a88487c79b (Fix compile errors in SGI console drivers) broke this
> > driver completely.
> >
> > And since nobody noticed for the past 3 years, move it into staging. I
> > think this will rot there and we will throw it away completely after
> > some time. Or maybe someone will volunteer to fix it ;).
> >
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Alan Cox <alan@linux.intel.com>
> > ---
> > Cc: linux-m68k@lists.linux-m68k.org
> > drivers/staging/Kconfig | 2 +
> > drivers/staging/Makefile | 1 +
> > drivers/staging/serial/68360serial.c | 2979 ++++++++++++++++++++++++++++++++++
> > drivers/staging/serial/Kconfig | 16 +
> > drivers/staging/serial/Makefile | 1 +
> > drivers/staging/serial/TODO | 6 +
> > drivers/tty/serial/68360serial.c | 2979 ----------------------------------
> > drivers/tty/serial/Kconfig | 17 -
> > drivers/tty/serial/Makefile | 1 -
> > 9 files changed, 3005 insertions(+), 2997 deletions(-)
> > create mode 100644 drivers/staging/serial/68360serial.c
> > create mode 100644 drivers/staging/serial/Kconfig
> > create mode 100644 drivers/staging/serial/Makefile
> > create mode 100644 drivers/staging/serial/TODO
> > delete mode 100644 drivers/tty/serial/68360serial.c
>
> 'git mv' and 'git format-patch --find-renames' would make this patch so
> much nicer.

That will happen automatically when I apply the patch, so don't worry
about it.

greg k-h