public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
	linus.walleij@linaro.org, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool
Date: Mon, 05 Sep 2011 20:51:38 +0100	[thread overview]
Message-ID: <1315252298.1243.21.camel@ted> (raw)
In-Reply-To: <1315249786-15387-1-git-send-email-bryan.wu@canonical.com>

On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it
> as module. So change this option back as tristate and treak the help
> message as well.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>

> ---
>  drivers/leds/Kconfig |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b591e72..1c35927 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
>  if NEW_LEDS
>  
>  config LEDS_CLASS
> -	bool "LED Class Support"
> +	tristate "LED Class Support"
>  	help
>  	  This option enables the led sysfs class in /sys/class/leds.  You'll
> -	  need this to do anything useful with LEDs.  If unsure, say N.
> +	  need this to do anything useful with LEDs.  If unsure, say M.
> +
> +	  Note: don't disable it as N, because plenty of led and trigger drivers
> +	  are using this option.
>  
>  comment "LED drivers"
>  



  parent reply	other threads:[~2011-09-05 20:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 19:09 [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool Bryan Wu
2011-09-05 19:09 ` [PATCH 2/2] Documentation: leds-class: fix a typo Bryan Wu
2011-09-05 19:52   ` Richard Purdie
2011-09-07 18:56     ` Randy Dunlap
2011-09-08 17:11     ` Randy Dunlap
2011-09-05 19:51 ` Richard Purdie [this message]
2011-09-05 20:49   ` [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool Bryan Wu
2011-09-29  8:07   ` Russell King - ARM Linux
2011-09-30  9:09     ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315252298.1243.21.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=bryan.wu@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox