Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages()

Wu Fengguang
2011-08-07T06:45:15Z

> > + bw = (u64)base_bw * bw >> BANDWIDTH_CALC_SHIFT;
> > + pause = (HZ * pages_dirtied + bw / 2) / (bw | 1);
> > + pause = min(pause, MAX_PAUSE);
>
> Fix this build warning:
>
> mm/page-writeback.c: In function ‘balance_dirty_pages’:
> mm/page-writeback.c:889:11: warning: comparison of distinct pointer types lacks a cast

Thanks! I'll fix it by changing `pause' to "long", since we'll have
negative pause time anyway when considering think time compensation.

Thanks,
Fengguang