From: Dan McGee <dpmcgee@gmail.com>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>
Subject: [PATCH] Ensure we actually allow UDMA/100
Date: Tue, 6 Sep 2011 15:45:22 -0500 [thread overview]
Message-ID: <1315341922-10286-1-git-send-email-dpmcgee@gmail.com> (raw)
In-Reply-To: <4E6674CA.6020405@pobox.com>
We were limiting to UDMA/66 instead.
---
Jeff,
Can this get folded in? Just realized the bitmask I used from Alan's patch wasn't right as it didn't actually allow UDMA/100, it was setting the max at UDMA/66. This simple fixup has been boot tested.
-Dan
drivers/ata/pata_sis.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index 54c41c7..810b7d6 100644
--- a/drivers/ata/pata_sis.c
+++ b/drivers/ata/pata_sis.c
@@ -526,7 +526,7 @@ static unsigned long sis_133_mode_filter(struct ata_device *adev, unsigned long
pci_read_config_dword(pdev, port, &t1);
/* if ATA133 is disabled, mask it out */
if (!(t1 & 0x08))
- mask &= ~(0xE0 << ATA_SHIFT_UDMA);
+ mask &= ~(0xC0 << ATA_SHIFT_UDMA);
return mask;
}
--
1.7.6.1
next prev parent reply other threads:[~2011-09-06 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 19:21 [PATCH 1/2] pata_sis: extract a sis_port_base() method Dan McGee
2011-09-06 19:21 ` [PATCH 2/2] pata_sis: add mode_filter method for certain sis5513 chipsets Dan McGee
2011-09-06 19:30 ` Jeff Garzik
2011-09-06 20:45 ` Dan McGee [this message]
[not found] ` <4E67402D.2030302@ru.mvista.com>
2011-09-07 16:02 ` [PATCH 1/2] pata_sis: extract a sis_port_base() method Dan McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315341922-10286-1-git-send-email-dpmcgee@gmail.com \
--to=dpmcgee@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).