From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933233Ab1IIJt5 (ORCPT ); Fri, 9 Sep 2011 05:49:57 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:47661 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933080Ab1IIJt4 (ORCPT ); Fri, 9 Sep 2011 05:49:56 -0400 Subject: [PATCH 1/2] ALSA: aoa: Remove obsolete cleanup for clientdata From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Johannes Berg , Wolfram Sang , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Date: Fri, 09 Sep 2011 17:49:44 +0800 Message-ID: <1315561784.2831.0.camel@phoenix> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The i2c core will clear the clientdata pointer automatically. We don't have to set the `data' field to NULL in remove() or if probe() failed anymore. Signed-off-by: Axel Lin --- sound/aoa/codecs/onyx.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c index 3687a6c..571f668 100644 --- a/sound/aoa/codecs/onyx.c +++ b/sound/aoa/codecs/onyx.c @@ -1067,7 +1067,6 @@ static int onyx_i2c_probe(struct i2c_client *client, printk(KERN_DEBUG PFX "created and attached onyx instance\n"); return 0; fail: - i2c_set_clientdata(client, NULL); kfree(onyx); return -ENODEV; } -- 1.7.4.1