public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Meyer <thomas@m3y3r.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	viro@zeniv.linux.org.uk, mingo@redhat.com
Subject: Re: a question regarding sys_poll() on x86_64 via tha ia32 layer
Date: Thu, 15 Sep 2011 15:00:55 +0200	[thread overview]
Message-ID: <1316091669.6545.79.camel@localhost.localdomain> (raw)
In-Reply-To: <1316089435.2893.6.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Am Donnerstag, den 15.09.2011, 14:23 +0200 schrieb Eric Dumazet:
> Its a plain bug, please submit a formal patch.
> 
> Probably not noticed because timer is set to more than 24 days.
> 

okay. I think a similar problem exists for sys_truncate() in ia32 layer
on x86_64:

the ia32 syscall is directly wired to sys_truncate(char *, long).

signed long will use %rbx on x86_64 and %ebx on x86.

call sys_truncate on x86_64 from x86 userspace will handle length
0xffffffff not as -1.

maybe an easy fix would be to change long to unsigned long for
sys_truncate(), like sys_ftruncate(). what do you think?

with kind regards
thomas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-09-15 13:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 11:40 a question regarding sys_poll() on x86_64 via tha ia32 layer Thomas Meyer
2011-09-15 12:23 ` Eric Dumazet
2011-09-15 13:00   ` Thomas Meyer [this message]
2011-09-15 14:37     ` Eric Dumazet
2011-09-15 17:44   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2011-09-13 12:04 Thomas Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316091669.6545.79.camel@localhost.localdomain \
    --to=thomas@m3y3r.de \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox