From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Graeme Gregory <gg@slimlogic.co.uk>,
Samuel Oritz <sameo@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 6/6 v5] regmap: Incorporate the regcache core into regmap
Date: Mon, 19 Sep 2011 14:34:05 +0100 [thread overview]
Message-ID: <1316439245-26221-7-git-send-email-dp@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1316439245-26221-1-git-send-email-dp@opensource.wolfsonmicro.com>
This patch incorporates the regcache core code into regmap. All previous
patches have been no-ops essentially up to this point.
The bulk read operation is not supported by regcache at the moment. This
will be implemented incrementally.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/base/regmap/regmap.c | 28 ++++++++++++++++++++++++++++
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index e7adfe7..602083f 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -146,6 +146,13 @@ struct regmap *regmap_init(struct device *dev,
map->readable_reg = config->readable_reg;
map->volatile_reg = config->volatile_reg;
map->precious_reg = config->precious_reg;
+ map->cache_type = config->cache_type;
+ map->reg_defaults = config->reg_defaults;
+ map->num_reg_defaults = config->num_reg_defaults;
+ map->num_reg_defaults_raw = config->num_reg_defaults_raw;
+ map->reg_defaults_raw = config->reg_defaults_raw;
+ map->cache_size_raw = (config->val_bits / 8) * config->num_reg_defaults_raw;
+ map->cache_word_size = config->val_bits / 8;
if (config->read_flag_mask || config->write_flag_mask) {
map->read_flag_mask = config->read_flag_mask;
@@ -208,6 +215,10 @@ struct regmap *regmap_init(struct device *dev,
goto err_map;
}
+ ret = regcache_init(map);
+ if (ret < 0)
+ goto err_map;
+
regmap_debugfs_init(map);
return map;
@@ -224,6 +235,7 @@ EXPORT_SYMBOL_GPL(regmap_init);
*/
void regmap_exit(struct regmap *map)
{
+ regcache_exit(map);
regmap_debugfs_exit(map);
kfree(map->work_buf);
kfree(map);
@@ -290,6 +302,12 @@ static int _regmap_write(struct regmap *map, unsigned int reg,
int ret;
BUG_ON(!map->format.format_write && !map->format.format_val);
+ if (!map->cache_bypass) {
+ ret = regcache_write(map, reg, val);
+ if (!ret || map->cache_only)
+ return 0;
+ }
+
trace_regmap_reg_write(map->dev, reg, val);
if (map->format.format_write) {
@@ -428,6 +446,14 @@ int regmap_read(struct regmap *map, unsigned int reg, unsigned int *val)
mutex_lock(&map->lock);
+ if (!map->cache_bypass) {
+ ret = regcache_read(map, reg, val);
+ if (!ret) {
+ mutex_unlock(&map->lock);
+ return 0;
+ }
+ }
+
ret = _regmap_read(map, reg, val);
mutex_unlock(&map->lock);
@@ -479,6 +505,8 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
int ret, i;
size_t val_bytes = map->format.val_bytes;
+ WARN_ON(map->cache_type != REGCACHE_NONE);
+
if (!map->format.parse_val)
return -EINVAL;
--
1.7.6.1
next prev parent reply other threads:[~2011-09-19 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 13:33 [PATCH 0/6 v5] Introduce caching support for regmap Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 1/6 v5] regmap: Introduce caching support Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 2/6 v5] regmap: Add the indexed cache support Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 3/6 v5] regmap: Add the rbtree " Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 4/6 v5] regmap: Add the LZO " Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 5/6 v5] regmap: Add the regcache_sync trace event Dimitris Papastamos
2011-09-19 13:34 ` Dimitris Papastamos [this message]
2011-09-19 15:57 ` [PATCH 6/6 v5] regmap: Incorporate the regcache core into regmap Lars-Peter Clausen
2011-09-19 16:13 ` Mark Brown
2011-09-19 16:20 ` Dimitris Papastamos
2011-09-19 16:28 ` Lars-Peter Clausen
2011-09-19 16:36 ` Mark Brown
2011-09-19 17:59 ` [PATCH 0/6 v5] Introduce caching support for regmap Mark Brown
2011-09-19 18:03 ` [PATCH 1/5] regmap: A cache type of _NONE behaves like a bypassed cache Mark Brown
2011-09-19 18:03 ` [PATCH 2/5] regmap: Prototype regcache_sync() Mark Brown
2011-09-19 18:03 ` [PATCH 3/5] regmap: Allow drivers to control cache_only flag Mark Brown
2011-09-19 18:03 ` [PATCH 4/5] regmap: Indentation tweaks in regcache Mark Brown
2011-09-19 18:03 ` [PATCH 5/5] regmap: Fix hookup of regcache into regmap Mark Brown
2011-09-19 18:04 ` [PATCH 0/6 v5] Introduce caching support for regmap Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316439245-26221-7-git-send-email-dp@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox