From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] posix-timers: move global timer id management to signal_struct v4
Date: Tue, 20 Sep 2011 01:15:04 +0200 [thread overview]
Message-ID: <1316474104.2455.32.camel@edumazet-laptop> (raw)
In-Reply-To: <4E77CC0E.2090206@linux.intel.com>
Le lundi 19 septembre 2011 à 16:11 -0700, Andi Kleen a écrit :
> > I'll provide not a hack but a clean patch for this.
>
> Great thanks.
> > I read once idr code, and its not messy at all.
> You're not serious right? Especially the locking scheme is just
> a extreme mess:
>
> sometimes takes a lock, sometimes requires locking from the caller
> even though the internal lock should be fine, sometimes uses unlocked
> bitmap
> operations outside a lock, all mixed with a partial RCU implementation,
> no assumption is documented of course. etc.etc. It's a great poster child
> for messy kernel code.
>
I dont know, I met more complex code in kernel, but I wont say where ;)
next prev parent reply other threads:[~2011-09-19 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 21:48 [PATCH 1/2] posix-timers: move global timer id management to signal_struct v4 Andi Kleen
2011-09-19 21:48 ` [PATCH 2/2] posix-timers: limit the number of posix timers per process v2 Andi Kleen
2011-09-19 22:23 ` [PATCH 1/2] posix-timers: move global timer id management to signal_struct v4 Eric Dumazet
2011-09-19 22:36 ` Andi Kleen
2011-09-19 22:41 ` Eric Dumazet
2011-09-19 23:07 ` Eric Dumazet
2011-09-19 23:11 ` Andi Kleen
2011-09-19 23:15 ` Eric Dumazet [this message]
2011-09-20 9:51 ` Thomas Gleixner
2011-09-20 9:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316474104.2455.32.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox