linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, yong.zhang0@gmail.com,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Maulik Mankad <x0082077@ti.com>,
	Robert Morell <rmorell@nvidia.com>,
	linux-usb@vger.kernel.org
Subject: [PATCH 01/57] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED
Date: Wed, 21 Sep 2011 17:28:02 +0800	[thread overview]
Message-ID: <1316597339-29861-2-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1316597339-29861-1-git-send-email-yong.zhang0@gmail.com>

Now, genirq keep irqs disabled when calling the action handler,
we don't need to disable irq by ourselves anymore.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
 drivers/usb/core/hcd.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index c1dabf0..8d0cd99 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2124,15 +2124,8 @@ EXPORT_SYMBOL_GPL(usb_bus_start_enum);
 irqreturn_t usb_hcd_irq (int irq, void *__hcd)
 {
 	struct usb_hcd		*hcd = __hcd;
-	unsigned long		flags;
 	irqreturn_t		rc;
 
-	/* IRQF_DISABLED doesn't work correctly with shared IRQs
-	 * when the first handler doesn't use it.  So let's just
-	 * assume it's never used.
-	 */
-	local_irq_save(flags);
-
 	if (unlikely(HCD_DEAD(hcd) || !HCD_HW_ACCESSIBLE(hcd))) {
 		rc = IRQ_NONE;
 	} else if (hcd->driver->irq(hcd) == IRQ_NONE) {
@@ -2144,7 +2137,6 @@ irqreturn_t usb_hcd_irq (int irq, void *__hcd)
 		rc = IRQ_HANDLED;
 	}
 
-	local_irq_restore(flags);
 	return rc;
 }
 EXPORT_SYMBOL_GPL(usb_hcd_irq);
@@ -2333,13 +2325,6 @@ static int usb_hcd_request_irqs(struct usb_hcd *hcd,
 
 	if (hcd->driver->irq) {
 
-		/* IRQF_DISABLED doesn't work as advertised when used together
-		 * with IRQF_SHARED. As usb_hcd_irq() will always disable
-		 * interrupts we can remove it here.
-		 */
-		if (irqflags & IRQF_SHARED)
-			irqflags &= ~IRQF_DISABLED;
-
 		snprintf(hcd->irq_descr, sizeof(hcd->irq_descr), "%s:usb%d",
 				hcd->driver->description, hcd->self.busnum);
 		retval = request_irq(irqnum, &usb_hcd_irq, irqflags,
-- 
1.7.4.1


  reply	other threads:[~2011-09-21  9:29 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21  9:28 [PATCH V1 00/57] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-09-21  9:28 ` Yong Zhang [this message]
2011-09-21  9:28 ` [PATCH 02/57] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21  9:28 ` [PATCH 04/57] avr32: " Yong Zhang
2011-09-21  9:28 ` [PATCH 05/57] cris: " Yong Zhang
2011-09-21  9:28 ` [PATCH 06/57] frv: " Yong Zhang
2011-09-21  9:28 ` [PATCH 07/57] h8300: " Yong Zhang
2011-09-21  9:28 ` [PATCH 08/57] ia64: " Yong Zhang
2011-09-21  9:28 ` [PATCH 09/57] m32r: " Yong Zhang
2011-09-21  9:28 ` [PATCH 10/57] m68k: " Yong Zhang
2011-09-21  9:28 ` [PATCH 11/57] microblaze: " Yong Zhang
2011-09-21  9:28 ` [PATCH 13/57] mn10300: " Yong Zhang
2011-09-21  9:28 ` [PATCH 14/57] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-09-21  9:28 ` [PATCH 15/57] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21  9:28 ` [PATCH 16/57] score: " Yong Zhang
2011-09-21  9:28 ` [PATCH 17/57] SH: " Yong Zhang
2011-09-21  9:28 ` [PATCH 18/57] sparc: " Yong Zhang
2011-09-21 17:40   ` David Miller
2011-09-21  9:28 ` [PATCH 19/57] um: " Yong Zhang
2011-09-21  9:28 ` [PATCH 20/57] unicore32: " Yong Zhang
2011-09-21  9:28 ` [PATCH 21/57] x86: irq: " Yong Zhang
2011-09-21  9:28 ` [PATCH 22/57] xtensa: " Yong Zhang
2011-09-21  9:28 ` [PATCH 23/57] clocksource: " Yong Zhang
2011-09-21  9:28 ` [PATCH 24/57] SCSI: " Yong Zhang
2011-09-21  9:28 ` [PATCH 25/57] ata: " Yong Zhang
2011-09-21 10:35   ` Wolfram Sang
2011-09-21  9:28 ` [PATCH 26/57] block: " Yong Zhang
2011-09-21  9:28 ` [PATCH 27/57] cdrom: " Yong Zhang
2011-09-21  9:28 ` [PATCH 28/57] driver/char: " Yong Zhang
2011-09-21  9:28 ` [PATCH 29/57] crypto: " Yong Zhang
2011-09-21  9:28 ` [PATCH 30/57] dmaengine: " Yong Zhang
2011-09-21  9:28 ` [PATCH 31/57] EDAC: " Yong Zhang
2011-09-21  9:28 ` [PATCH 32/57] i2c: " Yong Zhang
2011-09-21  9:28 ` [PATCH 33/57] infiniband: " Yong Zhang
2011-09-21  9:28 ` [PATCH 34/57] ISDN: " Yong Zhang
2011-09-21  9:28 ` [PATCH 36/57] drivers:misc:irq: " Yong Zhang
2011-09-21  9:28 ` [PATCH 37/57] mmc: irq: " Yong Zhang
2011-09-21 10:16   ` Guennadi Liakhovetski
2011-09-22 14:50   ` Kadiyala, Kishore
2011-09-21  9:28 ` [PATCH 38/57] mtd: " Yong Zhang
2011-09-21  9:28 ` [PATCH 40/57] dirvers/parisc: " Yong Zhang
2011-09-21 10:07   ` James Bottomley
2011-09-21 12:07     ` Yong Zhang
2011-09-21  9:28 ` [PATCH 41/57] pcmcia: " Yong Zhang
2011-09-21  9:28 ` [PATCH 42/57] sony-laptop:irq: " Yong Zhang
2011-09-21  9:28 ` [PATCH 43/57] PNP: irq: " Yong Zhang
2011-09-21 20:20   ` Bjorn Helgaas
2011-09-21  9:28 ` [PATCH 44/57] power_supply:irq: " Yong Zhang
2011-09-21  9:28 ` [PATCH 45/57] powerpc/ps3: irq: " Yong Zhang
2011-09-21  9:28 ` [PATCH 46/57] rtc: " Yong Zhang
2011-09-21  9:52   ` Wan ZongShun
2011-09-21 10:31   ` [rtc-linux] " Wolfram Sang
2011-09-21  9:28 ` [PATCH 47/57] spi: " Yong Zhang
2011-09-21  9:28 ` [PATCH 48/57] TTY: " Yong Zhang
2011-09-21  9:28 ` [PATCH 49/57] video: " Yong Zhang
2011-09-21 20:22   ` David Brown
2011-09-21  9:28 ` [PATCH 50/57] w1: " Yong Zhang
2011-09-21 10:06   ` Evgeniy Polyakov
2011-09-21  9:28 ` [PATCH 51/57] watchdog: " Yong Zhang
2011-09-21  9:28 ` [PATCH 52/57] xen: " Yong Zhang
2011-09-21  9:28 ` [PATCH 54/57] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-09-28 22:33   ` Bjorn Helgaas
2011-10-08  2:34     ` Yong Zhang
2011-09-21  9:28 ` [PATCH 55/57] hexagon: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 15:35   ` Richard Kuo
2011-09-22  8:08     ` Yong Zhang
2011-09-21  9:28 ` [PATCH 56/57] hwmon: " Yong Zhang
2011-09-21 19:07   ` Guenter Roeck
2011-09-21  9:28 ` [PATCH 57/57] genirq: " Yong Zhang
2011-09-21 12:27 ` [PATCH V1 00/57] Tree wide: cleanup IRQF_DISABLED Yong Zhang
     [not found] ` <1316597339-29861-40-git-send-email-yong.zhang0@gmail.com>
2011-09-21 17:40   ` [PATCH 39/57] net: irq: Remove IRQF_DISABLED David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316597339-29861-2-git-send-email-yong.zhang0@gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rmorell@nvidia.com \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=x0082077@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).