From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, yong.zhang0@gmail.com,
Chris Ball <cjb@laptop.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Ian Molton <ian@mnementh.co.uk>, Tony Lindgren <tony@atomide.com>,
Kishore Kadiyala <kishore.kadiyala@ti.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
Balaji T K <balajitk@ti.com>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: [PATCH 37/57] mmc: irq: Remove IRQF_DISABLED
Date: Wed, 21 Sep 2011 17:28:38 +0800 [thread overview]
Message-ID: <1316597339-29861-38-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1316597339-29861-1-git-send-email-yong.zhang0@gmail.com>
Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).
So now this flag is a NOOP and can be removed.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
drivers/mmc/host/omap_hsmmc.c | 5 ++---
drivers/mmc/host/tmio_mmc.c | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 21e4a79..75c6395 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2015,7 +2015,7 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
}
/* Request IRQ for MMC operations */
- ret = request_irq(host->irq, omap_hsmmc_irq, IRQF_DISABLED,
+ ret = request_irq(host->irq, omap_hsmmc_irq, 0,
mmc_hostname(mmc), host);
if (ret) {
dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
@@ -2043,8 +2043,7 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
if ((mmc_slot(host).card_detect_irq)) {
ret = request_irq(mmc_slot(host).card_detect_irq,
omap_hsmmc_cd_handler,
- IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING
- | IRQF_DISABLED,
+ IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
mmc_hostname(mmc), host);
if (ret) {
dev_dbg(mmc_dev(host->mmc),
diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
index 44a9668..a4ea102 100644
--- a/drivers/mmc/host/tmio_mmc.c
+++ b/drivers/mmc/host/tmio_mmc.c
@@ -88,8 +88,8 @@ static int __devinit tmio_mmc_probe(struct platform_device *pdev)
if (ret)
goto cell_disable;
- ret = request_irq(irq, tmio_mmc_irq, IRQF_DISABLED |
- IRQF_TRIGGER_FALLING, dev_name(&pdev->dev), host);
+ ret = request_irq(irq, tmio_mmc_irq, IRQF_TRIGGER_FALLING,
+ dev_name(&pdev->dev), host);
if (ret)
goto host_remove;
--
1.7.4.1
next prev parent reply other threads:[~2011-09-21 9:34 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 9:28 [PATCH V1 00/57] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` [PATCH 01/57] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-09-21 9:28 ` [PATCH 02/57] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` [PATCH 04/57] avr32: " Yong Zhang
2011-09-21 9:28 ` [PATCH 05/57] cris: " Yong Zhang
2011-09-21 9:28 ` [PATCH 06/57] frv: " Yong Zhang
2011-09-21 9:28 ` [PATCH 07/57] h8300: " Yong Zhang
2011-09-21 9:28 ` [PATCH 08/57] ia64: " Yong Zhang
2011-09-21 9:28 ` [PATCH 09/57] m32r: " Yong Zhang
2011-09-21 9:28 ` [PATCH 10/57] m68k: " Yong Zhang
2011-09-21 9:28 ` [PATCH 11/57] microblaze: " Yong Zhang
2011-09-21 9:28 ` [PATCH 13/57] mn10300: " Yong Zhang
2011-09-21 9:28 ` [PATCH 14/57] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` [PATCH 15/57] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` [PATCH 16/57] score: " Yong Zhang
2011-09-21 9:28 ` [PATCH 17/57] SH: " Yong Zhang
2011-09-21 9:28 ` [PATCH 18/57] sparc: " Yong Zhang
2011-09-21 17:40 ` David Miller
2011-09-21 9:28 ` [PATCH 19/57] um: " Yong Zhang
2011-09-21 9:28 ` [PATCH 20/57] unicore32: " Yong Zhang
2011-09-21 9:28 ` [PATCH 21/57] x86: irq: " Yong Zhang
2011-09-21 9:28 ` [PATCH 22/57] xtensa: " Yong Zhang
2011-09-21 9:28 ` [PATCH 23/57] clocksource: " Yong Zhang
2011-09-21 9:28 ` [PATCH 24/57] SCSI: " Yong Zhang
2011-09-21 9:28 ` [PATCH 25/57] ata: " Yong Zhang
2011-09-21 10:35 ` Wolfram Sang
2011-09-21 9:28 ` [PATCH 26/57] block: " Yong Zhang
2011-09-21 9:28 ` [PATCH 27/57] cdrom: " Yong Zhang
2011-09-21 9:28 ` [PATCH 28/57] driver/char: " Yong Zhang
2011-09-21 9:28 ` [PATCH 29/57] crypto: " Yong Zhang
2011-09-21 9:28 ` [PATCH 30/57] dmaengine: " Yong Zhang
2011-09-21 9:28 ` [PATCH 31/57] EDAC: " Yong Zhang
2011-09-21 9:28 ` [PATCH 32/57] i2c: " Yong Zhang
2011-09-21 9:28 ` [PATCH 33/57] infiniband: " Yong Zhang
2011-09-21 9:28 ` [PATCH 34/57] ISDN: " Yong Zhang
2011-09-21 9:28 ` [PATCH 36/57] drivers:misc:irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang [this message]
2011-09-21 10:16 ` [PATCH 37/57] mmc: irq: " Guennadi Liakhovetski
2011-09-22 14:50 ` Kadiyala, Kishore
2011-09-21 9:28 ` [PATCH 38/57] mtd: " Yong Zhang
2011-09-21 9:28 ` [PATCH 40/57] dirvers/parisc: " Yong Zhang
2011-09-21 10:07 ` James Bottomley
2011-09-21 12:07 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 41/57] pcmcia: " Yong Zhang
2011-09-21 9:28 ` [PATCH 42/57] sony-laptop:irq: " Yong Zhang
2011-09-21 9:28 ` [PATCH 43/57] PNP: irq: " Yong Zhang
2011-09-21 20:20 ` Bjorn Helgaas
2011-09-21 9:28 ` [PATCH 44/57] power_supply:irq: " Yong Zhang
2011-09-21 9:28 ` [PATCH 45/57] powerpc/ps3: irq: " Yong Zhang
2011-09-21 9:28 ` [PATCH 46/57] rtc: " Yong Zhang
2011-09-21 9:52 ` Wan ZongShun
2011-09-21 10:31 ` [rtc-linux] " Wolfram Sang
2011-09-21 9:28 ` [PATCH 47/57] spi: " Yong Zhang
2011-09-21 9:28 ` [PATCH 48/57] TTY: " Yong Zhang
2011-09-21 9:28 ` [PATCH 49/57] video: " Yong Zhang
2011-09-21 20:22 ` David Brown
2011-09-21 9:28 ` [PATCH 50/57] w1: " Yong Zhang
2011-09-21 10:06 ` Evgeniy Polyakov
2011-09-21 9:28 ` [PATCH 51/57] watchdog: " Yong Zhang
2011-09-21 9:28 ` [PATCH 52/57] xen: " Yong Zhang
2011-09-21 9:28 ` [PATCH 54/57] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-09-28 22:33 ` Bjorn Helgaas
2011-10-08 2:34 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 55/57] hexagon: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 15:35 ` Richard Kuo
2011-09-22 8:08 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 56/57] hwmon: " Yong Zhang
2011-09-21 19:07 ` Guenter Roeck
2011-09-21 9:28 ` [PATCH 57/57] genirq: " Yong Zhang
2011-09-21 12:27 ` [PATCH V1 00/57] Tree wide: cleanup IRQF_DISABLED Yong Zhang
[not found] ` <1316597339-29861-40-git-send-email-yong.zhang0@gmail.com>
2011-09-21 17:40 ` [PATCH 39/57] net: irq: Remove IRQF_DISABLED David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316597339-29861-38-git-send-email-yong.zhang0@gmail.com \
--to=yong.zhang0@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=balajitk@ti.com \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=kishore.kadiyala@ti.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).