From: Peter Zijlstra <peterz@infradead.org>
To: Don Zickus <dzickus@redhat.com>
Cc: x86@kernel.org, Andi Kleen <andi@firstfloor.org>,
Robert Richter <robert.richter@amd.com>,
ying.huang@intel.com, LKML <linux-kernel@vger.kernel.org>,
paulmck@linux.vnet.ibm.com, avi@redhat.com, jeremy@goop.org
Subject: Re: [V6][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs
Date: Mon, 26 Sep 2011 10:59:14 +0200 [thread overview]
Message-ID: <1317027554.9084.71.camel@twins> (raw)
In-Reply-To: <1316805435-14832-5-git-send-email-dzickus@redhat.com>
On Fri, 2011-09-23 at 15:17 -0400, Don Zickus wrote:
> + /*
> + * Use 'false' as back-to-back NMIs are dealt with one level up.
> + * Of course this makes having multiple 'unknown' handlers useless
> + * as only the first one is ever run (unless it can actually determine
> + * if it caused the NMI)
> + */
> + handled = nmi_handle(NMI_UNKNOWN, regs, false);
Shouldn't we then also add something like:
WARN_ON_ONCE(type == NMI_UNKNOWN && !list_empty(&desc->head));
to __setup_nmi()?
next prev parent reply other threads:[~2011-09-26 8:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 19:17 [V6][PATCH 0/6] x86, nmi: new NMI handling routines Don Zickus
2011-09-23 19:17 ` [V6][PATCH 1/6] x86, nmi: split out nmi from traps.c Don Zickus
2011-09-23 19:17 ` [V6][PATCH 2/6] x86, nmi: create new NMI handler routines Don Zickus
2011-09-23 19:17 ` [V6][PATCH 3/6] x86, nmi: wire up NMI handlers to new routines Don Zickus
2011-09-30 14:25 ` Robert Richter
2011-09-23 19:17 ` [V6][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs Don Zickus
2011-09-26 8:59 ` Peter Zijlstra [this message]
2011-09-26 12:55 ` Don Zickus
2011-09-28 10:31 ` Robert Richter
2011-09-28 12:37 ` Don Zickus
2011-09-28 16:51 ` Jeremy Fitzhardinge
2011-09-28 17:44 ` Don Zickus
2011-09-28 17:52 ` Jeremy Fitzhardinge
2011-10-02 10:07 ` Avi Kivity
2011-10-02 13:48 ` Andi Kleen
2011-10-02 14:04 ` Avi Kivity
2011-10-03 13:13 ` Don Zickus
2011-09-23 19:17 ` [V6][PATCH 5/6] x86, nmi: track NMI usage stats Don Zickus
2011-09-23 19:17 ` [V6][PATCH 6/6] x86, nmi: print out NMI stats in /proc/interrupts Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317027554.9084.71.camel@twins \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=dzickus@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox