* [PATCH] ACPI: check mutex release status
@ 2011-09-26 11:39 Davidlohr Bueso
2011-09-26 12:59 ` Lin Ming
0 siblings, 1 reply; 2+ messages in thread
From: Davidlohr Bueso @ 2011-09-26 11:39 UTC (permalink / raw)
To: Len Brown; +Cc: lkml, linux-acpi
From: Davidlohr Bueso <dave@gnu.org>
If this is not done we have a bogus ACPI_FAILURE() call.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
drivers/acpi/acpica/nsload.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpica/nsload.c b/drivers/acpi/acpica/nsload.c
index 5f7dc69..f3070fd 100644
--- a/drivers/acpi/acpica/nsload.c
+++ b/drivers/acpi/acpica/nsload.c
@@ -115,7 +115,7 @@ acpi_ns_load_table(u32 table_index, struct acpi_namespace_node *node)
}
unlock:
- (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
+ status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: check mutex release status
2011-09-26 11:39 [PATCH] ACPI: check mutex release status Davidlohr Bueso
@ 2011-09-26 12:59 ` Lin Ming
0 siblings, 0 replies; 2+ messages in thread
From: Lin Ming @ 2011-09-26 12:59 UTC (permalink / raw)
To: dave; +Cc: Len Brown, lkml, linux-acpi
On Mon, Sep 26, 2011 at 7:39 PM, Davidlohr Bueso <dave@gnu.org> wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> If this is not done we have a bogus ACPI_FAILURE() call.
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> drivers/acpi/acpica/nsload.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsload.c b/drivers/acpi/acpica/nsload.c
> index 5f7dc69..f3070fd 100644
> --- a/drivers/acpi/acpica/nsload.c
> +++ b/drivers/acpi/acpica/nsload.c
> @@ -115,7 +115,7 @@ acpi_ns_load_table(u32 table_index, struct acpi_namespace_node *node)
> }
>
> unlock:
> - (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
> + status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
No,
The status maybe set before the "goto unlock" statement.
Lin Ming
>
> if (ACPI_FAILURE(status)) {
> return_ACPI_STATUS(status);
> --
> 1.7.4.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-26 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 11:39 [PATCH] ACPI: check mutex release status Davidlohr Bueso
2011-09-26 12:59 ` Lin Ming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox