From: Bojan Smojver <bojan@rexursive.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH v5]: Improve performance of LZO hibernation
Date: Wed, 28 Sep 2011 17:54:16 +1000 [thread overview]
Message-ID: <1317196456.1998.24.camel@shrek.rexursive.com> (raw)
In-Reply-To: <CAOJsxLFGpU53AQRw-nKsz_Lz_QMDP+RDUD5J3bYzbAA_+ngaAA@mail.gmail.com>
On Wed, 2011-09-28 at 10:48 +0300, Pekka Enberg wrote:
> > The compression/decompression threads stop by breaking out of the
> loop.
> > At least they should, right? Did I misread some docs here?
>
> Yes, the threads are stopped. What happens after that? Will the
> hibernation process be aborted? How can this be tested?
I'm guessing here that you mean that parts of the kernel other than
hibernation code itself can do this (i.e. set the flag for the thread to
stop, so kthread_should_stop() returns true). Correct?
If that is a possibility (which I didn't take into account at all), I
will need to rewrite so that if such a thing happens, we abort the
hibernation process. It should not be difficult.
Right now, this would result in - well I don't know what exactly - most
likely corrupted data on disk or on memory.
--
Bojan
next prev parent reply other threads:[~2011-09-28 7:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 4:20 [PATCH v5]: Improve performance of LZO hibernation Bojan Smojver
2011-09-28 7:14 ` Pekka Enberg
2011-09-28 7:18 ` Bojan Smojver
2011-09-28 7:25 ` Pekka Enberg
2011-09-28 7:22 ` Pekka Enberg
2011-09-28 7:29 ` Bojan Smojver
2011-09-28 7:48 ` Pekka Enberg
2011-09-28 7:54 ` Bojan Smojver [this message]
2011-09-28 13:02 ` Pekka Enberg
2011-09-28 13:18 ` Bojan Smojver
2011-09-29 8:23 ` Bojan Smojver
2011-09-28 7:57 ` Bojan Smojver
2011-09-28 8:00 ` Bojan Smojver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317196456.1998.24.camel@shrek.rexursive.com \
--to=bojan@rexursive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox