From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, acme@redhat.com,
robert.richter@amd.com, ak@linux.intel.com, mingo@elte.hu
Subject: Re: [PATCH] perf: make perf.data more self-descriptive (v7)
Date: Wed, 28 Sep 2011 17:20:19 +0200 [thread overview]
Message-ID: <1317223219.24040.47.camel@twins> (raw)
In-Reply-To: <CABPqkBRJydnzYK=OXpX+fTXUwraSf4PzEfiDmMjZLyZRYgRiVw@mail.gmail.com>
On Wed, 2011-09-28 at 16:06 +0200, Stephane Eranian wrote:
> > + size_t len = 0;
> > + u32 i = 0;
> > + int ret = -1;
> > +
> > + ret = -1;
>
>
> Missed this yesterday. gcc-4.6 (e.g., Fedora 15) throws an error on this:
>
> util/header.c: In function ‘build_cpu_topo’:
> util/header.c:461:6: error: variable ‘ret’ set but not used
> [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> Sorry about that. That means v8 is on the way, hopefully the final attempt... Thanks.
Could we all please trim emails and not send html stuff?
prev parent reply other threads:[~2011-09-28 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 7:48 [PATCH] perf: make perf.data more self-descriptive (v7) Stephane Eranian
2011-09-28 13:38 ` David Ahern
[not found] ` <CABPqkBRJydnzYK=OXpX+fTXUwraSf4PzEfiDmMjZLyZRYgRiVw@mail.gmail.com>
2011-09-28 15:20 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317223219.24040.47.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox