Re: [PATCH 8/8] regmap: Ensure we scream if we enable cache bypass/only at the same time

Mark Brown
2011-09-29T10:25:33Z

On Thu, Sep 29, 2011 at 10:39:13AM +0100, Dimitris Papastamos wrote:

> void regcache_cache_only(struct regmap *map, bool enable)
> {
> + BUG_ON(map->cache_bypass && enable);
> mutex_lock(&map->lock);

I'd move these inside the lock otherwise there's an enable/enable race
where two threads check that things are safe simultaneously. I'd also
change to WARN_ON(), if nothing else it's hard to see BUG_ON()s that
occur prior to console output and PMICs are likely to trigger that sort
of stuff.