From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: axel.lin@gmail.com
Cc: Andrew Morton <akpm00@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
Date: Fri, 30 Sep 2011 11:44:42 +0100 [thread overview]
Message-ID: <1317379490.12332.145.camel@ted> (raw)
In-Reply-To: <CAF+7xWkQ6SX9aUjBuaCgNVwKoiaBoV6gXfOYfw3MBf9B2c_wiA@mail.gmail.com>
On Fri, 2011-09-30 at 07:45 +0800, Axel Lin wrote:
> >> Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
> >> Nothing in the tree references it?
> >
> > It sounds like someone has removed the sharpsl battery driver which did
> > use this. If this hook isn't used, low battery with high screen
> > backlight values will reset the device as the wiring isn't up to the
> > current draw.
> >
> It is removed by commit 13a542475d1c62a12c77abfa83a790245598fc61
> Author: Christoph Egger <siccegge@cs.fau.de>
> Date: Sun Jul 4 23:24:52 2010 +0800
>
> [ARM] pxa: removing dead BACKLIGHT_CORGI
>
> BACKLIGHT_CORGI was later renamed to BACKLIGHT_GENERIC and has not been
> used since then. As it's now safe to completely transition to LCD_CORGI
> driver, which incorprates both the LCD and backlight device.
>
> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>
> So, should we remove corgibl_limit_intensity/genericbl_limit_intensity
> since now it is not being used?
Does that code workaround the hardware issue I mention? I suspect not.
It seems nobody cares about that at this point though...
Cheers,
Richard
prev parent reply other threads:[~2011-09-30 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 2:12 [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity Axel Lin
2011-09-29 20:00 ` Andrew Morton
2011-09-29 20:22 ` Richard Purdie
2011-09-29 23:45 ` Axel Lin
2011-09-30 10:44 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317379490.12332.145.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=akpm00@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox