* [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
@ 2011-09-25 2:12 Axel Lin
2011-09-29 20:00 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2011-09-25 2:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Richard Purdie, Andrew Morton
The rename of corgibl_limit_intensity is missed in commit d00ba726
"backlight: Rename the corgi backlight driver to generic".
Let's fix it now.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/generic_bl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
index 8c6befd..adb1914 100644
--- a/drivers/video/backlight/generic_bl.c
+++ b/drivers/video/backlight/generic_bl.c
@@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)
* Called when the battery is low to limit the backlight intensity.
* If limit==0 clear any limit, otherwise limit the intensity
*/
-void corgibl_limit_intensity(int limit)
+void genericbl_limit_intensity(int limit)
{
struct backlight_device *bd = generic_backlight_device;
@@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)
backlight_update_status(generic_backlight_device);
mutex_unlock(&bd->ops_lock);
}
-EXPORT_SYMBOL(corgibl_limit_intensity);
+EXPORT_SYMBOL(genericbl_limit_intensity);
static const struct backlight_ops genericbl_ops = {
.options = BL_CORE_SUSPENDRESUME,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
2011-09-25 2:12 [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity Axel Lin
@ 2011-09-29 20:00 ` Andrew Morton
2011-09-29 20:22 ` Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2011-09-29 20:00 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Richard Purdie, Andrew Morton
On Sun, 25 Sep 2011 10:12:33 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> The rename of corgibl_limit_intensity is missed in commit d00ba726
> "backlight: Rename the corgi backlight driver to generic".
> Let's fix it now.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
> drivers/video/backlight/generic_bl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> index 8c6befd..adb1914 100644
> --- a/drivers/video/backlight/generic_bl.c
> +++ b/drivers/video/backlight/generic_bl.c
> @@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> * Called when the battery is low to limit the backlight intensity.
> * If limit==0 clear any limit, otherwise limit the intensity
> */
> -void corgibl_limit_intensity(int limit)
> +void genericbl_limit_intensity(int limit)
> {
> struct backlight_device *bd = generic_backlight_device;
>
> @@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)
> backlight_update_status(generic_backlight_device);
> mutex_unlock(&bd->ops_lock);
> }
> -EXPORT_SYMBOL(corgibl_limit_intensity);
> +EXPORT_SYMBOL(genericbl_limit_intensity);
>
Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
Nothing in the tree references it?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
2011-09-29 20:00 ` Andrew Morton
@ 2011-09-29 20:22 ` Richard Purdie
2011-09-29 23:45 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2011-09-29 20:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Axel Lin, linux-kernel, Andrew Morton
On Thu, 2011-09-29 at 13:00 -0700, Andrew Morton wrote:
> On Sun, 25 Sep 2011 10:12:33 +0800
> Axel Lin <axel.lin@gmail.com> wrote:
>
> > The rename of corgibl_limit_intensity is missed in commit d00ba726
> > "backlight: Rename the corgi backlight driver to generic".
> > Let's fix it now.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > Cc: Richard Purdie <rpurdie@rpsys.net>
> > ---
> > drivers/video/backlight/generic_bl.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> > index 8c6befd..adb1914 100644
> > --- a/drivers/video/backlight/generic_bl.c
> > +++ b/drivers/video/backlight/generic_bl.c
> > @@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> > * Called when the battery is low to limit the backlight intensity.
> > * If limit==0 clear any limit, otherwise limit the intensity
> > */
> > -void corgibl_limit_intensity(int limit)
> > +void genericbl_limit_intensity(int limit)
> > {
> > struct backlight_device *bd = generic_backlight_device;
> >
> > @@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)
> > backlight_update_status(generic_backlight_device);
> > mutex_unlock(&bd->ops_lock);
> > }
> > -EXPORT_SYMBOL(corgibl_limit_intensity);
> > +EXPORT_SYMBOL(genericbl_limit_intensity);
> >
>
> Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
> Nothing in the tree references it?
It sounds like someone has removed the sharpsl battery driver which did
use this. If this hook isn't used, low battery with high screen
backlight values will reset the device as the wiring isn't up to the
current draw.
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
2011-09-29 20:22 ` Richard Purdie
@ 2011-09-29 23:45 ` Axel Lin
2011-09-30 10:44 ` Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2011-09-29 23:45 UTC (permalink / raw)
To: Richard Purdie; +Cc: Andrew Morton, linux-kernel, Andrew Morton
>> Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
>> Nothing in the tree references it?
>
> It sounds like someone has removed the sharpsl battery driver which did
> use this. If this hook isn't used, low battery with high screen
> backlight values will reset the device as the wiring isn't up to the
> current draw.
>
It is removed by commit 13a542475d1c62a12c77abfa83a790245598fc61
Author: Christoph Egger <siccegge@cs.fau.de>
Date: Sun Jul 4 23:24:52 2010 +0800
[ARM] pxa: removing dead BACKLIGHT_CORGI
BACKLIGHT_CORGI was later renamed to BACKLIGHT_GENERIC and has not been
used since then. As it's now safe to completely transition to LCD_CORGI
driver, which incorprates both the LCD and backlight device.
Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
So, should we remove corgibl_limit_intensity/genericbl_limit_intensity
since now it is not being used?
> Richard
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
2011-09-29 23:45 ` Axel Lin
@ 2011-09-30 10:44 ` Richard Purdie
0 siblings, 0 replies; 5+ messages in thread
From: Richard Purdie @ 2011-09-30 10:44 UTC (permalink / raw)
To: axel.lin; +Cc: Andrew Morton, linux-kernel, Andrew Morton
On Fri, 2011-09-30 at 07:45 +0800, Axel Lin wrote:
> >> Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
> >> Nothing in the tree references it?
> >
> > It sounds like someone has removed the sharpsl battery driver which did
> > use this. If this hook isn't used, low battery with high screen
> > backlight values will reset the device as the wiring isn't up to the
> > current draw.
> >
> It is removed by commit 13a542475d1c62a12c77abfa83a790245598fc61
> Author: Christoph Egger <siccegge@cs.fau.de>
> Date: Sun Jul 4 23:24:52 2010 +0800
>
> [ARM] pxa: removing dead BACKLIGHT_CORGI
>
> BACKLIGHT_CORGI was later renamed to BACKLIGHT_GENERIC and has not been
> used since then. As it's now safe to completely transition to LCD_CORGI
> driver, which incorprates both the LCD and backlight device.
>
> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>
> So, should we remove corgibl_limit_intensity/genericbl_limit_intensity
> since now it is not being used?
Does that code workaround the hardware issue I mention? I suspect not.
It seems nobody cares about that at this point though...
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-30 10:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-25 2:12 [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity Axel Lin
2011-09-29 20:00 ` Andrew Morton
2011-09-29 20:22 ` Richard Purdie
2011-09-29 23:45 ` Axel Lin
2011-09-30 10:44 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox