Re: [RFC][PATCH 4/5] signal: Add signal->ctrl_lock for job control

Matt Fleming
2011-09-30T15:36:21Z

On Fri, 2011-09-30 at 17:30 +0200, Peter Zijlstra wrote:
> On Fri, 2011-09-30 at 16:12 +0100, Matt Fleming wrote:
> > + assert_spin_locked(&t->sighand->siglock);
> > + assert_spin_locked(&t->signal->ctrl_lock);
>
> There's also lockdep_assert_held(), the difference is that
> assert_spin_locked() will always generate code, and only checks that the
> lock is held, not that we are the current owner.
>
> lockdep_assert_held() will only generate code for lockdep kernels and
> will in fact check that the specified lock is held by the current task.

Aha! Yes, that's what I want, not assert_spin_locked(). Thanks!

--
Matt Fleming, Intel Open Source Technology Center