From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Matt Fleming <matt@console-pimps.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Anirudh Badam <abadam@cs.princeton.edu>
Subject: Re: [RFC][PATCH 4/5] signal: Add signal->ctrl_lock for job control
Date: Fri, 30 Sep 2011 17:30:27 +0200 [thread overview]
Message-ID: <1317396627.12973.7.camel@twins> (raw)
In-Reply-To: <1317395577-14091-5-git-send-email-matt@console-pimps.org>
On Fri, 2011-09-30 at 16:12 +0100, Matt Fleming wrote:
> + assert_spin_locked(&t->sighand->siglock);
> + assert_spin_locked(&t->signal->ctrl_lock);
There's also lockdep_assert_held(), the difference is that
assert_spin_locked() will always generate code, and only checks that the
lock is held, not that we are the current owner.
lockdep_assert_held() will only generate code for lockdep kernels and
will in fact check that the specified lock is held by the current task.
next prev parent reply other threads:[~2011-09-30 15:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 15:12 [RFC][PATCH 0/5] Signal scalability series Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 1/5] signal: Document signal locking rules Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 2/5] signal: Add rwlock to protect sighand->action Matt Fleming
2011-09-30 15:25 ` Peter Zijlstra
2011-09-30 15:56 ` Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 3/5] signal: Reduce sighand->siglock hold time in get_signal_to_deliver() Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 4/5] signal: Add signal->ctrl_lock for job control Matt Fleming
2011-09-30 15:30 ` Peter Zijlstra [this message]
2011-09-30 15:36 ` Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 5/5] signal: Split siglock into shared_siglock and per-thread siglock Matt Fleming
2011-09-30 16:52 ` [RFC][PATCH 0/5] Signal scalability series Oleg Nesterov
2011-09-30 18:54 ` Oleg Nesterov
2011-09-30 20:00 ` Matt Fleming
2011-09-30 23:56 ` Tejun Heo
2011-10-01 10:16 ` Matt Fleming
2011-10-01 13:03 ` Peter Zijlstra
2011-10-03 1:38 ` Tejun Heo
2011-10-03 13:56 ` Thomas Gleixner
2011-10-04 7:37 ` Tejun Heo
2011-10-03 13:07 ` Oleg Nesterov
2011-10-03 15:22 ` Peter Zijlstra
2011-10-04 17:14 ` Oleg Nesterov
2011-10-04 17:52 ` Oleg Nesterov
2011-10-04 17:54 ` Linus Torvalds
2011-10-04 18:13 ` Oleg Nesterov
2011-10-03 13:16 ` Oleg Nesterov
2011-10-04 8:56 ` Matt Fleming
2011-10-04 17:29 ` Oleg Nesterov
2011-09-30 22:30 ` Andi Kleen
2011-10-01 9:35 ` Matt Fleming
2011-10-03 15:28 ` Linus Torvalds
2011-10-03 15:43 ` Matt Fleming
2011-10-03 16:35 ` Oleg Nesterov
2011-10-03 20:58 ` Matt Fleming
2011-10-03 21:45 ` Linus Torvalds
2011-10-03 22:13 ` Thomas Gleixner
2011-10-04 8:20 ` Matt Fleming
2011-10-04 17:39 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317396627.12973.7.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=abadam@cs.princeton.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox