From: Joe Perches <joe@perches.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] udf : enable error print in udf_read_tagged().
Date: Mon, 03 Oct 2011 05:57:46 -0700 [thread overview]
Message-ID: <1317646666.3866.3.camel@Joe-Laptop> (raw)
In-Reply-To: <1317626352-29971-1-git-send-email-linkinjeon@gmail.com>
On Mon, 2011-10-03 at 16:19 +0900, Namjae Jeon wrote:
> And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also.
[]
> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
[]
> @@ -19,18 +21,15 @@
> #undef UDFFS_DEBUG
>
> #ifdef UDFFS_DEBUG
> -#define udf_debug(f, a...) \
> -do { \
> - printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
> - __FILE__, __LINE__, __func__); \
> - printk(f, ##a); \
> -} while (0)
> +#define udf_debug(fmt, ...) \
> + pr_debug("DEBUG %s:%d:%s: ", fmt, \
> + __FILE__, __LINE__, __func__, __VA_ARGS__);
This doesn't compile properly if UDFFS_DEBUG is
#defined.
No comma should be between "DEBUG %s:%d:%s: " and fmt.
next prev parent reply other threads:[~2011-10-03 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 7:19 [PATCH 1/2 v2] udf : enable error print in udf_read_tagged() Namjae Jeon
2011-10-03 12:57 ` Joe Perches [this message]
2011-10-03 13:58 ` NamJae Jeon
2011-10-03 22:17 ` Joe Perches
2011-10-03 23:20 ` NamJae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317646666.3866.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=jack@suse.cz \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox