Re: [V7][PATCH 0/6] x86, nmi: new NMI handling routines

[Peter Zijlstra <peterz@infradead.org>]

On Mon, 2011-10-03 at 11:56 -0400, Don Zickus wrote:
> On Mon, Oct 03, 2011 at 05:52:38PM +0200, Peter Zijlstra wrote:
> > 
> > Also fixed:
> > 
> > drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_nmi’:
> > drivers/char/ipmi/ipmi_watchdog.c:1091: error: ‘NMI_HANDLED’ undeclared (first use in this function)
> > drivers/char/ipmi/ipmi_watchdog.c:1091: error: (Each undeclared identifier is reported only once
> > drivers/char/ipmi/ipmi_watchdog.c:1091: error: for each function it appears in.)
> > drivers/char/ipmi/ipmi_watchdog.c:1096: error: ‘NMI_DONE’ undeclared (first use in this function)
> > drivers/char/ipmi/ipmi_watchdog.c: In function ‘check_parms’:
> > drivers/char/ipmi/ipmi_watchdog.c:1280: error: implicit declaration of function ‘register_nmi_handler’
> > drivers/char/ipmi/ipmi_watchdog.c:1280: error: ‘NMI_UNKNOWN’ undeclared (first use in this function)
> > drivers/char/ipmi/ipmi_watchdog.c:1289: error: implicit declaration of function ‘unregister_nmi_handler’
> > drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_wdog_init’:
> > drivers/char/ipmi/ipmi_watchdog.c:1327: error: ‘NMI_UNKNOWN’ undeclared (first use in this function)
> > drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_wdog_exit’:
> > drivers/char/ipmi/ipmi_watchdog.c:1348: error: ‘NMI_UNKNOWN’ undeclared (first use in this function)
> 
> Wow. Sorry about that.  I compiled my changes before I submitted.  I guess
> next time I should 'make clean' before compiling to catch these.

I didn't need that, I build an allnoconfig (which got me a fail with the
IBS patches), then an allyesconfig (which got me the earlier fail) and
this came from my regular config which included the ipmi crap because
Ingo hit this same fail earlier (-v5 or so) and everybody forgot to tell
you :/

Anyway, no worries, they're all pretty trivial.. now all I need is to
convince Ingo to take them :-)