Re: [PATCH 3/9] Staging: comedi: fix printk issue in cb_pcidas.c

[Joe Perches <joe@perches.com>]

On Tue, 2011-10-04 at 10:30 +1100, Ryan Mallon wrote:
> On 30/09/11 23:18, Ravishankar Karkala Mallikarjunayya wrote:
> 
> > This is a patch to the cb_pcidas.c file that fixes up a printk warning found by the checkpatch.pl tool
> > 
> > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> > ---
> >  drivers/staging/comedi/drivers/cb_pcidas.c |   21 +++++++++++++--------
> >  1 files changed, 13 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c
> > index 9dec153..9d16c6c 100644
> > --- a/drivers/staging/comedi/drivers/cb_pcidas.c
> > +++ b/drivers/staging/comedi/drivers/cb_pcidas.c
> > @@ -565,7 +565,8 @@ static int cb_pcidas_attach(struct comedi_device *dev,
> >  	int index;
> >  	int i;
> >  
> > -	pr_info("comedi%d: cb_pcidas: ", dev->minor);
> > +	dev_info(&pcidev->dev, "comedi%d: cb_pcidas:\n",
> > +		dev->minor);
> 
> This printk can probably be removed now. It's just noise. Similar in
> other places too.

Looking a bit further at the patch and the function it
modifies, it converts dev->minor to &pcidev->dev.  In the
function, pcidev is initialized to NULL a couple of lines
before the dev_info so this proposed patch is truly broken.

I've now officially given up looking at comedi printk cleanups.

Most of the proposed patches have very high error rates and
the submitters don't seem to want to improve their submissions
or lower their error rate significantly.

I could probably fix the whole thing correctly in an afternoon.

I'd add and use comedi_<level> functions that Greg doesn't like
and until Greg changes his mind, I won't bother.