From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Venki Pallipadi <venki@google.com>, Ingo Molnar <mingo@elte.hu>,
Prarit Bhargava <prarit@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: [patch v2 1/2] sched: Use resched IPI to kick off the nohz idle balance
Date: Tue, 04 Oct 2011 11:05:21 +0200 [thread overview]
Message-ID: <1317719121.25926.15.camel@twins> (raw)
In-Reply-To: <20111003220934.834943260@sbsiddha-desk.sc.intel.com>
On Mon, 2011-10-03 at 15:09 -0700, Suresh Siddha wrote:
> + smp_mb();
> + /*
> + * Use smp_send_reschedule() instead of resched_cpu().
> + * This way we generate a sched IPI on the target cpu which
> + * is idle. And the softirq performing nohz idle load balance
> + * will be run before returning from the IPI.
> + */
> + smp_send_reschedule(ilb_cpu);
Now the only thing missing is where the matching barrier is, does
receiving an interrupt imply a mb? If so that wants mentioning
somewhere, otherwise people will wonder how we can ever read the right
value.
next prev parent reply other threads:[~2011-10-04 9:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 22:09 [patch v2 1/2] sched: Use resched IPI to kick off the nohz idle balance Suresh Siddha
2011-10-03 22:09 ` [patch v2 2/2] sched: Request for idle balance during nohz idle load balance Suresh Siddha
2011-10-04 9:05 ` Peter Zijlstra [this message]
2011-10-04 18:03 ` [patch v2 1/2] sched: Use resched IPI to kick off the nohz idle balance Suresh Siddha
2011-10-06 17:27 ` Vivek Goyal
2011-10-08 0:09 ` Suresh Siddha
2011-10-10 13:52 ` Vivek Goyal
2011-10-10 14:06 ` Peter Zijlstra
2011-10-10 15:25 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317719121.25926.15.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=stable@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox