Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

[Andreas Gruenbacher <andreas.gruenbacher@gmail.com>]

On Tue, 2011-10-04 at 23:53 -0700, Greg KH wrote:
> "now" meaning which version of quilt?  I still see this on 0.48 if that
> matters.

In the repository (master branch).

> > > > Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
> > > > line as a valid email address name, but I've been living with that one
> > > > for years...
> > 
> > That's not even valid in email addresses.  The proper way would be to
> > double-quote the "display name" which probably contains the comma, but
> > then quilt's edmail script still won't understand it.  Is this a real
> > problem?
> 
> Yes, quoting is the correct thing to do, but that does not usually
> happen in "Signed-off-by:" lines in kernel patches.
> 
> Actually, I think this is even a problem when the name is quoted
> properly, I've had to fix that up in patches by hand.

Yes, proper quoting currently isn't enough.

> And yes, this is a problem, I run into at least 1-2 patches per stable
> kernel release with this issue.  I looked into fixing it and somehow the
> email parsing logic was wierd and I couldn't figure out how to resolve
> it.

Okay, I'll have another look ...

Andreas