public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Mike Arthur <linux@wolfsonmicro.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Ian Lartey <ian@opensource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 02/10] ASoC: wm8711: Convert to snd_soc_cache_sync
Date: Thu, 06 Oct 2011 14:13:02 +0800	[thread overview]
Message-ID: <1317881582.13399.5.camel@phoenix> (raw)
In-Reply-To: <1317881417.13399.1.camel@phoenix>

Convert to snd_soc_cache_sync for sync reg_cache with the hardware.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/wm8711.c |   19 ++++++++-----------
 1 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/sound/soc/codecs/wm8711.c b/sound/soc/codecs/wm8711.c
index 47c7fd5..b489edf 100644
--- a/sound/soc/codecs/wm8711.c
+++ b/sound/soc/codecs/wm8711.c
@@ -291,6 +291,7 @@ static int wm8711_set_dai_fmt(struct snd_soc_dai *codec_dai,
 static int wm8711_set_bias_level(struct snd_soc_codec *codec,
 	enum snd_soc_bias_level level)
 {
+	int ret;
 	u16 reg = snd_soc_read(codec, WM8711_PWR) & 0xff7f;
 
 	switch (level) {
@@ -300,6 +301,13 @@ static int wm8711_set_bias_level(struct snd_soc_codec *codec,
 	case SND_SOC_BIAS_PREPARE:
 		break;
 	case SND_SOC_BIAS_STANDBY:
+		if (codec->dapm.bias_level == SND_SOC_BIAS_OFF) {
+			ret = snd_soc_cache_sync(codec);
+			if (ret < 0) {
+				dev_err(codec->dev, "Failed to sync cache: %d\n", ret);
+				return ret;
+			}
+		}
 		snd_soc_write(codec, WM8711_PWR, reg | 0x0040);
 		break;
 	case SND_SOC_BIAS_OFF:
@@ -346,18 +354,7 @@ static int wm8711_suspend(struct snd_soc_codec *codec, pm_message_t state)
 
 static int wm8711_resume(struct snd_soc_codec *codec)
 {
-	int i;
-	u8 data[2];
-	u16 *cache = codec->reg_cache;
-
-	/* Sync reg_cache with the hardware */
-	for (i = 0; i < ARRAY_SIZE(wm8711_reg); i++) {
-		data[0] = (i << 1) | ((cache[i] >> 8) & 0x0001);
-		data[1] = cache[i] & 0x00ff;
-		codec->hw_write(codec->control_data, data, 2);
-	}
 	wm8711_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-
 	return 0;
 }
 
-- 
1.7.4.1




  parent reply	other threads:[~2011-10-06  6:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06  6:10 [PATCH 00/10] Convert wm8xxx codec drivers to use snd_soc_cache_sync Axel Lin
2011-10-06  6:11 ` [PATCH 01/10] ASoC: wm8510: Convert to snd_soc_cache_sync Axel Lin
2011-10-06 13:22   ` Mark Brown
2011-10-06  6:13 ` Axel Lin [this message]
2011-10-06  6:14 ` [PATCH 03/10] ASoC: wm8731: " Axel Lin
2011-10-06  6:15 ` [PATCH 04/10] ASoC: wm8750: " Axel Lin
2011-10-06  6:16 ` [PATCH 05/10] ASoC: wm8776: " Axel Lin
2011-10-06  6:17 ` [PATCH 06/10] ASoC: wm8940: " Axel Lin
2011-10-06 11:28   ` Jonathan Cameron
2011-10-06 11:33     ` Axel Lin
2011-10-06 13:18     ` Mark Brown
2011-10-06 13:35       ` Jonathan Cameron
2011-10-06  6:18 ` [PATCH 07/10] ASoC: wm8960: " Axel Lin
2011-10-06  7:25   ` [PATCH 07/10 v2] " Axel Lin
2011-10-06  6:19 ` [PATCH 08/10] ASoC: wm8971: " Axel Lin
2011-10-06  6:20 ` [PATCH 09/10] ASoC: wm8974: " Axel Lin
2011-10-06  6:21 ` [PATCH 10/10] ASoC: wm8988: " Axel Lin
2011-10-06  6:52 ` [PATCH 00/10] Convert wm8xxx codec drivers to use snd_soc_cache_sync Axel Lin
2011-10-06  7:10   ` Axel Lin
2011-10-06 10:14 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317881582.13399.5.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=ian@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox