Re: [PATCH 01/11 RESEND] ASoC: wm8510: Convert to snd_soc_write

Mark Brown
2011-10-07T09:57:25Z

On Fri, Oct 07, 2011 at 10:40:20AM +0800, Axel Lin wrote:

> +static void wm8510_sync_cache(struct snd_soc_codec *codec)
> +{
> + short i;
> + u16 *cache;
> +
> + if (!codec->cache_sync)
> + return;
> + codec->cache_only = 0;
> + codec->cache_bypass = 1;
> + /* restore cache */
> + cache = codec->reg_cache;
> + for (i = 0; i < codec->driver->reg_cache_size; i++) {
> + if (i == WM8510_RESET || cache[i] == wm8510_reg[i])
> + continue;
> + snd_soc_write(codec, i, cache[i]);
> + }
> + codec->cache_bypass = 0;
> + codec->cache_sync = 0;

The usual trick for avoiding this is to provide a register default value
for the reset register and then write that value when the chip is reset.
This then means that the write to the reset register is suppressed by
the cache restore code when it skips writes of default registers.

Thanks for doing this work.