From: Bojan Smojver <bojan@rexursive.com>
To: linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH v9]: Improve performance of LZO/plain hibernation, check image with CRC32
Date: Mon, 10 Oct 2011 11:35:20 +1100 [thread overview]
Message-ID: <1318206920.1991.27.camel@shrek.rexursive.com> (raw)
On Mon, 2011-10-10 at 10:53 +1100, Bojan Smojver wrote:
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -27,6 +27,7 @@ config HIBERNATION
> select HIBERNATE_CALLBACKS
> select LZO_COMPRESS
> select LZO_DECOMPRESS
> + select CRC32
> ---help---
> Enable the suspend to disk (STD) functionality, which is usually
> called "hibernation" in user interfaces. STD checkpoints the
Not sure whether this is really required (I mean select CRC32). The docs
say:
------------------
config CRC32
tristate "CRC32 functions"
default y
select BITREVERSE
help
This option is provided for the case where no in-kernel-tree
modules require CRC32 functions, but a module built outside the
kernel tree does. Such modules that use library CRC32 functions
------------------
Obviously, hibernation is in the kernel, so maybe we don't need this
after all.
If you know for sure, feel free to point it out.
--
Bojan
next reply other threads:[~2011-10-10 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 0:35 Bojan Smojver [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-10 0:10 [PATCH v9]: Improve performance of LZO/plain hibernation, check image with CRC32 Bojan Smojver
2011-10-09 23:53 Bojan Smojver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318206920.1991.27.camel@shrek.rexursive.com \
--to=bojan@rexursive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox