public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns_raw
@ 2011-10-17 18:58 Dan McGee
  2011-10-17 19:09 ` john stultz
  0 siblings, 1 reply; 2+ messages in thread
From: Dan McGee @ 2011-10-17 18:58 UTC (permalink / raw)
  To: John Stultz, Thomas Gleixner, linux-kernel

The whole point of this function is to return a value not touched by
NTP; unfortunately the comment got copied wholesale without adjustment
from the timekeeping_get_ns function above.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
---
 kernel/time/timekeeping.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 2b021b0e..a5846a8 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -131,7 +131,7 @@ static inline s64 timekeeping_get_ns_raw(void)
 	/* calculate the delta since the last update_wall_time: */
 	cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
 
-	/* return delta convert to nanoseconds using ntp adjusted mult. */
+	/* return delta convert to nanoseconds. */
 	return clocksource_cyc2ns(cycle_delta, clock->mult, clock->shift);
 }
 
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns_raw
  2011-10-17 18:58 [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns_raw Dan McGee
@ 2011-10-17 19:09 ` john stultz
  0 siblings, 0 replies; 2+ messages in thread
From: john stultz @ 2011-10-17 19:09 UTC (permalink / raw)
  To: Dan McGee; +Cc: Thomas Gleixner, linux-kernel

On Mon, 2011-10-17 at 13:58 -0500, Dan McGee wrote:
> The whole point of this function is to return a value not touched by
> NTP; unfortunately the comment got copied wholesale without adjustment
> from the timekeeping_get_ns function above.
> 
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> ---
>  kernel/time/timekeeping.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 2b021b0e..a5846a8 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -131,7 +131,7 @@ static inline s64 timekeeping_get_ns_raw(void)
>  	/* calculate the delta since the last update_wall_time: */
>  	cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
> 
> -	/* return delta convert to nanoseconds using ntp adjusted mult. */
> +	/* return delta convert to nanoseconds. */
>  	return clocksource_cyc2ns(cycle_delta, clock->mult, clock->shift);
>  }

Thanks for catching this! I'll apply it to my queue!
-john



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-17 19:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-17 18:58 [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns_raw Dan McGee
2011-10-17 19:09 ` john stultz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox