From: Steven Rostedt <rostedt@goodmis.org>
To: David Smith <dsmith@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] Tracepoint: add exec tracepoint
Date: Tue, 18 Oct 2011 16:26:48 -0400 [thread overview]
Message-ID: <1318969608.3712.7.camel@frodo> (raw)
In-Reply-To: <4E9DD418.7030005@redhat.com>
On Tue, 2011-10-18 at 14:31 -0500, David Smith wrote:
> On 10/18/2011 01:58 PM, Christoph Hellwig wrote:
>
> > On Tue, Oct 18, 2011 at 01:41:35PM -0500, David Smith wrote:
> >> Added general purpose exec tracepoint. The 'bprm' argument gives details of the exec.
> >
> > Given that you only need the filename from the bprm please just pass
> > it directly.
>
>
> Thanks for looking at the patch.
>
> I'm not totally opposed to this change, but passing bprm allows custom
> tracepoint handlers to look at other fields in bprm besides filename,
> which could be useful (depending on your needs).
I like flexible tracepoints too.
>
> But, I don't have a real strong opinion here.
>
I rather pass the pointer. If we pass the string, gcc may not optimize
when tracing is disabled and still do the work to dereference the
pointer unnecessarily.
-- Steve
prev parent reply other threads:[~2011-10-18 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 18:41 [RFC PATCH] Tracepoint: add exec tracepoint David Smith
2011-10-18 18:58 ` Christoph Hellwig
2011-10-18 19:31 ` David Smith
2011-10-18 20:26 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318969608.3712.7.camel@frodo \
--to=rostedt@goodmis.org \
--cc=dsmith@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox