From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Wolfram Sang <w.sang@pengutronix.de>,
Andy Whitcroft <apw@canonical.com>
Subject: [PATCH] checkpatch: improve error message for p1-check
Date: Wed, 19 Oct 2011 14:33:03 +0200 [thread overview]
Message-ID: <1319027583-17842-1-git-send-email-w.sang@pengutronix.de> (raw)
The old error message was not precise. State now explicitly that the
prefix exists as a file/directory. Also change the conclusion ("appears
to be") into an instruction ("make sure").
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Andy Whitcroft <apw@canonical.com>
---
scripts/checkpatch.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3dfc471..4bb4f88 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1506,7 +1506,7 @@ sub process {
if (!$file && $tree && $p1_prefix ne '' &&
-e "$root/$p1_prefix") {
WARN("PATCH_PREFIX",
- "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
+ "patch prefix '$p1_prefix' exists as file/directory. Make sure this isn't a -p0 patch\n");
}
if ($realfile =~ m@^include/asm/@) {
--
1.7.6.3
next reply other threads:[~2011-10-19 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 12:33 Wolfram Sang [this message]
2011-10-26 20:30 ` [PATCH] checkpatch: improve error message for p1-check David Rientjes
2011-10-26 22:51 ` Joe Perches
2011-10-26 23:08 ` David Rientjes
2011-10-26 23:14 ` Joe Perches
2011-10-26 23:34 ` David Rientjes
2011-10-26 23:44 ` Joe Perches
2011-10-27 20:11 ` David Rientjes
2011-10-27 20:29 ` Joe Perches
2011-10-27 21:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319027583-17842-1-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=apw@canonical.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).