* [PATCH] ASoC: ak4671: Use snd_soc_update_bits for read-modify-write
@ 2011-10-20 2:54 Axel Lin
2011-10-20 9:47 ` Girdwood, Liam
2011-10-20 14:08 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-20 2:54 UTC (permalink / raw)
To: linux-kernel
Cc: Joonyoung Shim, Lars-Peter Clausen, Liam Girdwood, Mark Brown,
alsa-devel
Use snd_soc_update_bits for read-modify-write register access instead of
open-coding it using snd_soc_read and snd_soc_write
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/ak4671.c | 18 ++++++------------
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/sound/soc/codecs/ak4671.c b/sound/soc/codecs/ak4671.c
index 41e3d55..de9ff66 100644
--- a/sound/soc/codecs/ak4671.c
+++ b/sound/soc/codecs/ak4671.c
@@ -168,18 +168,15 @@ static int ak4671_out2_event(struct snd_soc_dapm_widget *w,
struct snd_kcontrol *kcontrol, int event)
{
struct snd_soc_codec *codec = w->codec;
- u8 reg;
switch (event) {
case SND_SOC_DAPM_POST_PMU:
- reg = snd_soc_read(codec, AK4671_LOUT2_POWER_MANAGERMENT);
- reg |= AK4671_MUTEN;
- snd_soc_write(codec, AK4671_LOUT2_POWER_MANAGERMENT, reg);
+ snd_soc_update_bits(codec, AK4671_LOUT2_POWER_MANAGERMENT,
+ AK4671_MUTEN, AK4671_MUTEN);
break;
case SND_SOC_DAPM_PRE_PMD:
- reg = snd_soc_read(codec, AK4671_LOUT2_POWER_MANAGERMENT);
- reg &= ~AK4671_MUTEN;
- snd_soc_write(codec, AK4671_LOUT2_POWER_MANAGERMENT, reg);
+ snd_soc_update_bits(codec, AK4671_LOUT2_POWER_MANAGERMENT,
+ AK4671_MUTEN, 0);
break;
}
@@ -575,15 +572,12 @@ static int ak4671_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
static int ak4671_set_bias_level(struct snd_soc_codec *codec,
enum snd_soc_bias_level level)
{
- u8 reg;
-
switch (level) {
case SND_SOC_BIAS_ON:
case SND_SOC_BIAS_PREPARE:
case SND_SOC_BIAS_STANDBY:
- reg = snd_soc_read(codec, AK4671_AD_DA_POWER_MANAGEMENT);
- snd_soc_write(codec, AK4671_AD_DA_POWER_MANAGEMENT,
- reg | AK4671_PMVCM);
+ snd_soc_update_bits(codec, AK4671_AD_DA_POWER_MANAGEMENT,
+ AK4671_PMVCM, AK4671_PMVCM);
break;
case SND_SOC_BIAS_OFF:
snd_soc_write(codec, AK4671_AD_DA_POWER_MANAGEMENT, 0x00);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: ak4671: Use snd_soc_update_bits for read-modify-write
2011-10-20 2:54 [PATCH] ASoC: ak4671: Use snd_soc_update_bits for read-modify-write Axel Lin
@ 2011-10-20 9:47 ` Girdwood, Liam
2011-10-20 14:08 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Girdwood, Liam @ 2011-10-20 9:47 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Joonyoung Shim, Lars-Peter Clausen, Mark Brown,
alsa-devel
On 20 October 2011 03:54, Axel Lin <axel.lin@gmail.com> wrote:
> Use snd_soc_update_bits for read-modify-write register access instead of
> open-coding it using snd_soc_read and snd_soc_write
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/ak4671.c | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ak4671: Use snd_soc_update_bits for read-modify-write
2011-10-20 2:54 [PATCH] ASoC: ak4671: Use snd_soc_update_bits for read-modify-write Axel Lin
2011-10-20 9:47 ` Girdwood, Liam
@ 2011-10-20 14:08 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-10-20 14:08 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Joonyoung Shim, Lars-Peter Clausen, Liam Girdwood,
alsa-devel
On Thu, Oct 20, 2011 at 10:54:13AM +0800, Axel Lin wrote:
> Use snd_soc_update_bits for read-modify-write register access instead of
> open-coding it using snd_soc_read and snd_soc_write
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-20 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-20 2:54 [PATCH] ASoC: ak4671: Use snd_soc_update_bits for read-modify-write Axel Lin
2011-10-20 9:47 ` Girdwood, Liam
2011-10-20 14:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).