linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Clemens Ladisch <clemens@ladisch.de>,
	Corey Minyard <minyard@acm.org>,
	Mark Gross <mark.gross@intel.com>,
	openipmi-developer@lists.sourceforge.net
Subject: [PATCH 27/49] driver/char: irq: Remove IRQF_DISABLED
Date: Sat, 22 Oct 2011 17:56:39 +0800	[thread overview]
Message-ID: <1319277421-9203-28-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1319277421-9203-1-git-send-email-yong.zhang0@gmail.com>

Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Acked-by: Corey Minyard <cminyard@mvista.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/hpet.c              |    2 +-
 drivers/char/ipmi/ipmi_si_intf.c |    4 ++--
 drivers/char/nwbutton.c          |    2 +-
 drivers/char/rtc.c               |    4 ++--
 drivers/char/snsc.c              |    2 +-
 drivers/char/snsc_event.c        |    2 +-
 drivers/char/tlclk.c             |    2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index c9aeb7f..2a2ecac 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -532,7 +532,7 @@ static int hpet_ioctl_ieon(struct hpet_dev *devp)
 
 		sprintf(devp->hd_name, "hpet%d", (int)(devp - hpetp->hp_dev));
 		irq_flags = devp->hd_flags & HPET_SHARED_IRQ
-						? IRQF_SHARED : IRQF_DISABLED;
+						? IRQF_SHARED : 0;
 		if (request_irq(irq, hpet_interrupt, irq_flags,
 				devp->hd_name, (void *)devp)) {
 			printk(KERN_ERR "hpet: IRQ %d is not free\n", irq);
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 9397ab4..44e8da3 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1336,7 +1336,7 @@ static int std_irq_setup(struct smi_info *info)
 	if (info->si_type == SI_BT) {
 		rv = request_irq(info->irq,
 				 si_bt_irq_handler,
-				 IRQF_SHARED | IRQF_DISABLED,
+				 IRQF_SHARED,
 				 DEVICE_NAME,
 				 info);
 		if (!rv)
@@ -1346,7 +1346,7 @@ static int std_irq_setup(struct smi_info *info)
 	} else
 		rv = request_irq(info->irq,
 				 si_irq_handler,
-				 IRQF_SHARED | IRQF_DISABLED,
+				 IRQF_SHARED,
 				 DEVICE_NAME,
 				 info);
 	if (rv) {
diff --git a/drivers/char/nwbutton.c b/drivers/char/nwbutton.c
index 04a480f..36aaf43 100644
--- a/drivers/char/nwbutton.c
+++ b/drivers/char/nwbutton.c
@@ -220,7 +220,7 @@ static int __init nwbutton_init(void)
 		return -EBUSY;
 	}
 
-	if (request_irq (IRQ_NETWINDER_BUTTON, button_handler, IRQF_DISABLED,
+	if (request_irq (IRQ_NETWINDER_BUTTON, button_handler, 0,
 			"nwbutton", NULL)) {
 		printk (KERN_WARNING "nwbutton: IRQ %d is not free.\n",
 				IRQ_NETWINDER_BUTTON);
diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index ccd124a..d1478cd 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -228,7 +228,7 @@ static inline unsigned char rtc_is_updating(void)
 
 #ifdef RTC_IRQ
 /*
- *	A very tiny interrupt handler. It runs with IRQF_DISABLED set,
+ *	A very tiny interrupt handler. It runs with irqs disabled,
  *	but there is possibility of conflicting with the set_rtc_mmss()
  *	call (the rtc irq and the timer irq can easily run at the same
  *	time in two different CPUs). So we need to serialize
@@ -1041,7 +1041,7 @@ no_irq:
 		rtc_int_handler_ptr = rtc_interrupt;
 	}
 
-	if (request_irq(RTC_IRQ, rtc_int_handler_ptr, IRQF_DISABLED,
+	if (request_irq(RTC_IRQ, rtc_int_handler_ptr, 0,
 			"rtc", NULL)) {
 		/* Yeah right, seeing as irq 8 doesn't even hit the bus. */
 		rtc_has_irq = 0;
diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c
index 5816b39..d3464ef 100644
--- a/drivers/char/snsc.c
+++ b/drivers/char/snsc.c
@@ -108,7 +108,7 @@ scdrv_open(struct inode *inode, struct file *file)
 	/* hook this subchannel up to the system controller interrupt */
 	mutex_lock(&scdrv_mutex);
 	rv = request_irq(SGI_UART_VECTOR, scdrv_interrupt,
-			 IRQF_SHARED | IRQF_DISABLED,
+			 IRQF_SHARED,
 			 SYSCTL_BASENAME, sd);
 	if (rv) {
 		ia64_sn_irtr_close(sd->sd_nasid, sd->sd_subch);
diff --git a/drivers/char/snsc_event.c b/drivers/char/snsc_event.c
index ee15694..a35978c 100644
--- a/drivers/char/snsc_event.c
+++ b/drivers/char/snsc_event.c
@@ -292,7 +292,7 @@ scdrv_event_init(struct sysctl_data_s *scd)
 
 	/* hook event subchannel up to the system controller interrupt */
 	rv = request_irq(SGI_UART_VECTOR, scdrv_event_interrupt,
-			 IRQF_SHARED | IRQF_DISABLED,
+			 IRQF_SHARED,
 			 "system controller events", event_sd);
 	if (rv) {
 		printk(KERN_WARNING "%s: irq request failed (%d)\n",
diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index 0c964cd..771e48e 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -222,7 +222,7 @@ static int tlclk_open(struct inode *inode, struct file *filp)
 	/* This device is wired through the FPGA IO space of the ATCA blade
 	 * we can't share this IRQ */
 	result = request_irq(telclk_interrupt, &tlclk_interrupt,
-			     IRQF_DISABLED, "telco_clock", tlclk_interrupt);
+			     0, "telco_clock", tlclk_interrupt);
 	if (result == -EBUSY)
 		printk(KERN_ERR "tlclk: Interrupt can't be reserved.\n");
 	else
-- 
1.7.1


  parent reply	other threads:[~2011-10-22 10:10 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-22  9:56 [PATCH V3 00/49] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 01/49] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-10-22  9:56 ` [PATCH 02/49] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 04/49] avr32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 05/49] cris: " Yong Zhang
2011-10-22  9:56 ` [PATCH 06/49] frv: " Yong Zhang
2011-10-22  9:56 ` [PATCH 07/49] h8300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 08/49] ia64: " Yong Zhang
2011-10-22  9:56 ` [PATCH 09/49] m32r: " Yong Zhang
2011-10-22  9:56 ` [PATCH 10/49] m68k: " Yong Zhang
2011-10-22  9:56 ` [PATCH 11/49] microblaze: " Yong Zhang
2011-10-22  9:56 ` [PATCH 12/49] MIPS: " Yong Zhang
2011-11-04 12:21   ` Ralf Baechle
2011-11-07  2:10     ` Yong Zhang
2011-11-07  2:49       ` Stephen Rothwell
2011-11-07  3:06         ` Yong Zhang
2011-10-22  9:56 ` [PATCH 13/49] mn10300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 14/49] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 15/49] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-23  1:57   ` Geoff Levand
2011-10-22  9:56 ` [PATCH 16/49] SH: " Yong Zhang
2011-10-28  6:17   ` Paul Mundt
2011-10-22  9:56 ` [PATCH 17/49] sparc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 18/49] um: " Yong Zhang
2011-10-28 10:54   ` Richard Weinberger
2011-10-28 11:51     ` Yong Zhang
2011-10-22  9:56 ` [PATCH 19/49] unicore32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 20/49] x86: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 21/49] xtensa: " Yong Zhang
2011-10-22  9:56 ` [PATCH 22/49] score: " Yong Zhang
2011-10-22  9:56 ` [PATCH 23/49] clocksource: " Yong Zhang
2011-10-22  9:56 ` [PATCH 24/49] SCSI: " Yong Zhang
2011-10-22  9:56 ` [PATCH 25/49] block: " Yong Zhang
2011-10-22  9:56 ` [PATCH 26/49] cdrom: " Yong Zhang
2011-10-22  9:56 ` Yong Zhang [this message]
2011-10-22  9:56 ` [PATCH 28/49] crypto: " Yong Zhang
2011-10-22  9:56 ` [PATCH 29/49] dmaengine: " Yong Zhang
2011-10-22  9:56 ` [PATCH 30/49] EDAC: " Yong Zhang
2011-10-22  9:56 ` [PATCH 31/49] ISDN: " Yong Zhang
2011-10-22  9:56 ` [PATCH 32/49] media: " Yong Zhang
2011-10-22  9:56 ` [PATCH 33/49] drivers:misc:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 34/49] mtd: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 35/49] net: " Yong Zhang
2011-10-22  9:56 ` [PATCH 36/49] dirvers/parisc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 37/49] pcmcia: " Yong Zhang
2012-02-05 21:11   ` Dominik Brodowski
2011-10-22  9:56 ` [PATCH 38/49] sony-laptop:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 39/49] PNP: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 40/49] power_supply:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 41/49] powerpc/ps3: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 42/49] rtc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 43/49] spi: " Yong Zhang
2011-10-24 12:14   ` Grant Likely
2011-10-22  9:56 ` [PATCH 44/49] w1: " Yong Zhang
2011-10-22  9:56 ` [PATCH 45/49] watchdog: " Yong Zhang
2011-10-22  9:56 ` [PATCH 46/49] xen: " Yong Zhang
2011-10-22  9:56 ` [PATCH 47/49] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-10-22  9:57 ` [PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22 13:16   ` Tanmay Upadhyay
2011-10-22  9:57 ` [PATCH 49/49] genirq: " Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319277421-9203-28-git-send-email-yong.zhang0@gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.gross@intel.com \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).