linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, David Howells <dhowells@redhat.com>
Subject: [PATCH 06/49] frv: irq: Remove IRQF_DISABLED
Date: Sat, 22 Oct 2011 17:56:18 +0800	[thread overview]
Message-ID: <1319277421-9203-7-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1319277421-9203-1-git-send-email-yong.zhang0@gmail.com>

Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: David Howells <dhowells@redhat.com>
---
 arch/frv/kernel/irq-mb93091.c |    8 ++++----
 arch/frv/kernel/irq-mb93093.c |    1 -
 arch/frv/kernel/irq-mb93493.c |    4 ++--
 arch/frv/kernel/time.c        |    1 -
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/arch/frv/kernel/irq-mb93091.c b/arch/frv/kernel/irq-mb93091.c
index 9afc2ea..f4dfc0b 100644
--- a/arch/frv/kernel/irq-mb93091.c
+++ b/arch/frv/kernel/irq-mb93091.c
@@ -108,25 +108,25 @@ static irqreturn_t fpga_interrupt(int irq, void *_mask)
 static struct irqaction fpga_irq[4]  = {
 	[0] = {
 		.handler	= fpga_interrupt,
-		.flags		= IRQF_DISABLED | IRQF_SHARED,
+		.flags		= IRQF_SHARED,
 		.name		= "fpga.0",
 		.dev_id		= (void *) 0x0028UL,
 	},
 	[1] = {
 		.handler	= fpga_interrupt,
-		.flags		= IRQF_DISABLED | IRQF_SHARED,
+		.flags		= IRQF_SHARED,
 		.name		= "fpga.1",
 		.dev_id		= (void *) 0x0050UL,
 	},
 	[2] = {
 		.handler	= fpga_interrupt,
-		.flags		= IRQF_DISABLED | IRQF_SHARED,
+		.flags		= IRQF_SHARED,
 		.name		= "fpga.2",
 		.dev_id		= (void *) 0x1c00UL,
 	},
 	[3] = {
 		.handler	= fpga_interrupt,
-		.flags		= IRQF_DISABLED | IRQF_SHARED,
+		.flags		= IRQF_SHARED,
 		.name		= "fpga.3",
 		.dev_id		= (void *) 0x6386UL,
 	}
diff --git a/arch/frv/kernel/irq-mb93093.c b/arch/frv/kernel/irq-mb93093.c
index 4d4ad09..bac526d 100644
--- a/arch/frv/kernel/irq-mb93093.c
+++ b/arch/frv/kernel/irq-mb93093.c
@@ -106,7 +106,6 @@ static irqreturn_t fpga_interrupt(int irq, void *_mask)
 static struct irqaction fpga_irq[1]  = {
 	[0] = {
 		.handler	= fpga_interrupt,
-		.flags		= IRQF_DISABLED,
 		.name		= "fpga.0",
 		.dev_id		= (void *) 0x0700UL,
 	}
diff --git a/arch/frv/kernel/irq-mb93493.c b/arch/frv/kernel/irq-mb93493.c
index 4d034c7..b632726 100644
--- a/arch/frv/kernel/irq-mb93493.c
+++ b/arch/frv/kernel/irq-mb93493.c
@@ -119,13 +119,13 @@ static irqreturn_t mb93493_interrupt(int irq, void *_piqsr)
 static struct irqaction mb93493_irq[2]  = {
 	[0] = {
 		.handler	= mb93493_interrupt,
-		.flags		= IRQF_DISABLED | IRQF_SHARED,
+		.flags		= IRQF_SHARED,
 		.name		= "mb93493.0",
 		.dev_id		= (void *) __addr_MB93493_IQSR(0),
 	},
 	[1] = {
 		.handler	= mb93493_interrupt,
-		.flags		= IRQF_DISABLED | IRQF_SHARED,
+		.flags		= IRQF_SHARED,
 		.name		= "mb93493.1",
 		.dev_id		= (void *) __addr_MB93493_IQSR(1),
 	}
diff --git a/arch/frv/kernel/time.c b/arch/frv/kernel/time.c
index b457de4..332e00b 100644
--- a/arch/frv/kernel/time.c
+++ b/arch/frv/kernel/time.c
@@ -44,7 +44,6 @@ static irqreturn_t timer_interrupt(int irq, void *dummy);
 
 static struct irqaction timer_irq  = {
 	.handler = timer_interrupt,
-	.flags = IRQF_DISABLED,
 	.name = "timer",
 };
 
-- 
1.7.1


  parent reply	other threads:[~2011-10-22 10:00 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-22  9:56 [PATCH V3 00/49] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 01/49] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-10-22  9:56 ` [PATCH 02/49] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 04/49] avr32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 05/49] cris: " Yong Zhang
2011-10-22  9:56 ` Yong Zhang [this message]
2011-10-22  9:56 ` [PATCH 07/49] h8300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 08/49] ia64: " Yong Zhang
2011-10-22  9:56 ` [PATCH 09/49] m32r: " Yong Zhang
2011-10-22  9:56 ` [PATCH 10/49] m68k: " Yong Zhang
2011-10-22  9:56 ` [PATCH 11/49] microblaze: " Yong Zhang
2011-10-22  9:56 ` [PATCH 12/49] MIPS: " Yong Zhang
2011-11-04 12:21   ` Ralf Baechle
2011-11-07  2:10     ` Yong Zhang
2011-11-07  2:49       ` Stephen Rothwell
2011-11-07  3:06         ` Yong Zhang
2011-10-22  9:56 ` [PATCH 13/49] mn10300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 14/49] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 15/49] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-23  1:57   ` Geoff Levand
2011-10-22  9:56 ` [PATCH 16/49] SH: " Yong Zhang
2011-10-28  6:17   ` Paul Mundt
2011-10-22  9:56 ` [PATCH 17/49] sparc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 18/49] um: " Yong Zhang
2011-10-28 10:54   ` Richard Weinberger
2011-10-28 11:51     ` Yong Zhang
2011-10-22  9:56 ` [PATCH 19/49] unicore32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 20/49] x86: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 21/49] xtensa: " Yong Zhang
2011-10-22  9:56 ` [PATCH 22/49] score: " Yong Zhang
2011-10-22  9:56 ` [PATCH 23/49] clocksource: " Yong Zhang
2011-10-22  9:56 ` [PATCH 24/49] SCSI: " Yong Zhang
2011-10-22  9:56 ` [PATCH 25/49] block: " Yong Zhang
2011-10-22  9:56 ` [PATCH 26/49] cdrom: " Yong Zhang
2011-10-22  9:56 ` [PATCH 27/49] driver/char: " Yong Zhang
2011-10-22  9:56 ` [PATCH 28/49] crypto: " Yong Zhang
2011-10-22  9:56 ` [PATCH 29/49] dmaengine: " Yong Zhang
2011-10-22  9:56 ` [PATCH 30/49] EDAC: " Yong Zhang
2011-10-22  9:56 ` [PATCH 31/49] ISDN: " Yong Zhang
2011-10-22  9:56 ` [PATCH 32/49] media: " Yong Zhang
2011-10-22  9:56 ` [PATCH 33/49] drivers:misc:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 34/49] mtd: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 35/49] net: " Yong Zhang
2011-10-22  9:56 ` [PATCH 36/49] dirvers/parisc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 37/49] pcmcia: " Yong Zhang
2012-02-05 21:11   ` Dominik Brodowski
2011-10-22  9:56 ` [PATCH 38/49] sony-laptop:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 39/49] PNP: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 40/49] power_supply:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 41/49] powerpc/ps3: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 42/49] rtc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 43/49] spi: " Yong Zhang
2011-10-24 12:14   ` Grant Likely
2011-10-22  9:56 ` [PATCH 44/49] w1: " Yong Zhang
2011-10-22  9:56 ` [PATCH 45/49] watchdog: " Yong Zhang
2011-10-22  9:56 ` [PATCH 46/49] xen: " Yong Zhang
2011-10-22  9:56 ` [PATCH 47/49] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-10-22  9:57 ` [PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22 13:16   ` Tanmay Upadhyay
2011-10-22  9:57 ` [PATCH 49/49] genirq: " Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319277421-9203-7-git-send-email-yong.zhang0@gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).