From: Joe Perches <joe@perches.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Anil Ravindranath <anil_ravindranath@pmc-sierra.com>,
davej@redhat.com
Subject: Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
Date: Mon, 24 Oct 2011 16:07:05 -0700 [thread overview]
Message-ID: <1319497625.2094.4.camel@Joe-Laptop> (raw)
In-Reply-To: <alpine.LNX.2.00.1110250055310.19795@swampdragon.chaosbits.net>
On Tue, 2011-10-25 at 00:57 +0200, Jesper Juhl wrote:
> On Tue, 25 Oct 2011, richard -rw- weinberger wrote:
> > On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches <joe@perches.com> wrote:
> > > On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> > We could grep for "k[mzc]alloc(GFP_".
> >
> I like that idea. That's exactely how I find these; by doing
> egrep -R "[kv][mcz]alloc *\( *GFP_"
> on the source tree.
> Might as well be in checkpatch.pl
Well, also from a year ago...
https://lkml.org/lkml/2010/10/31/121
next prev parent reply other threads:[~2011-10-24 23:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 22:38 [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl() Jesper Juhl
2011-10-24 22:42 ` Joe Perches
2011-10-24 22:50 ` richard -rw- weinberger
2011-10-24 22:54 ` Dave Jones
2011-10-24 23:03 ` richard -rw- weinberger
2011-10-24 23:13 ` Jesper Juhl
2011-10-24 23:06 ` Jesper Juhl
2011-10-24 22:57 ` Jesper Juhl
2011-10-24 23:07 ` Joe Perches [this message]
2011-10-24 22:51 ` Jesper Juhl
2011-10-24 23:17 ` Joe Perches
2011-10-24 23:18 ` Dave Jones
2011-10-24 23:24 ` richard -rw- weinberger
2011-10-25 1:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319497625.2094.4.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=JBottomley@parallels.com \
--cc=anil_ravindranath@pmc-sierra.com \
--cc=davej@redhat.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox