From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754781Ab1JXXHJ (ORCPT ); Mon, 24 Oct 2011 19:07:09 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:34254 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754293Ab1JXXHG (ORCPT ); Mon, 24 Oct 2011 19:07:06 -0400 Message-ID: <1319497625.2094.4.camel@Joe-Laptop> Subject: Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl() From: Joe Perches To: Jesper Juhl Cc: richard -rw- weinberger , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Anil Ravindranath , davej@redhat.com Date: Mon, 24 Oct 2011 16:07:05 -0700 In-Reply-To: References: <1319496149.2094.3.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-10-25 at 00:57 +0200, Jesper Juhl wrote: > On Tue, 25 Oct 2011, richard -rw- weinberger wrote: > > On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches wrote: > > > On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote: > > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()? > > We could grep for "k[mzc]alloc(GFP_". > > > I like that idea. That's exactely how I find these; by doing > egrep -R "[kv][mcz]alloc *\( *GFP_" > on the source tree. > Might as well be in checkpatch.pl Well, also from a year ago... https://lkml.org/lkml/2010/10/31/121