From: Joe Perches <joe@perches.com>
To: David Rientjes <rientjes@google.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: improve error message for p1-check
Date: Wed, 26 Oct 2011 15:51:07 -0700 [thread overview]
Message-ID: <1319669467.21924.18.camel@Joe-Laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1110261329240.23111@chino.kir.corp.google.com>
On Wed, 2011-10-26 at 13:30 -0700, David Rientjes wrote:
> On Wed, 19 Oct 2011, Wolfram Sang wrote:
> > The old error message was not precise. State now explicitly that the
> > prefix exists as a file/directory. Also change the conclusion ("appears
> > to be") into an instruction ("make sure").
> Why can't we suppress this warning unless both prefixes appear as files or
> directories in the cwd? ('a' and 'b' if using git format-patch)
I sent a suggested patch that checked $root/$patched_file
https://lkml.org/lkml/2011/10/19/257
next prev parent reply other threads:[~2011-10-26 22:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 12:33 [PATCH] checkpatch: improve error message for p1-check Wolfram Sang
2011-10-26 20:30 ` David Rientjes
2011-10-26 22:51 ` Joe Perches [this message]
2011-10-26 23:08 ` David Rientjes
2011-10-26 23:14 ` Joe Perches
2011-10-26 23:34 ` David Rientjes
2011-10-26 23:44 ` Joe Perches
2011-10-27 20:11 ` David Rientjes
2011-10-27 20:29 ` Joe Perches
2011-10-27 21:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319669467.21924.18.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox