From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: holzheu@linux.vnet.ibm.com,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vivek Goyal <vgoyal@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
schwidefsky@de.ibm.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH] kdump: Add udev events for memory online/offline
Date: Fri, 28 Oct 2011 15:57:16 -0700 [thread overview]
Message-ID: <1319842636.23600.186.camel@nimitz> (raw)
In-Reply-To: <20111028154137.1aeb5a6c.akpm@linux-foundation.org>
On Fri, 2011-10-28 at 15:41 -0700, Andrew Morton wrote:
> > + } else if (!strncmp(buf, "offline", min((int)count, 7))) {
> > ret = memory_block_change_state(mem, MEM_OFFLINE, MEM_ONLINE);
> > -
> > + if (ret == 0)
> > + kobject_uevent(&dev->kobj, KOBJ_OFFLINE);
> > + }
>
> ot: what on earth is up with that min() thing which
> Dave-who-doesn't-know-about-min_t added to the strncmp() calls?
My first reaction was, "that's not my code!", but git seems to disagree
with me. So I'll go and blame it on being young and stupid in 2005.
Reading it, I also think it's probably buggy.
echo -n "o" > state
would be interesting. I think it'll fall in to the 'online' case.
While probably not that common, it's certainly unexpected. I'll send a
patch to fix it up.
-- Dave
next prev parent reply other threads:[~2011-10-28 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 16:08 kdump: No udev events for memory hotplug? Michael Holzheu
2011-10-26 19:24 ` Vivek Goyal
2011-10-27 7:30 ` Heiko Carstens
2011-10-27 9:32 ` [PATCH] kdump: Add udev events for memory online/offline Michael Holzheu
2011-10-28 22:41 ` Andrew Morton
2011-10-28 22:57 ` Dave Hansen [this message]
2011-10-28 22:46 ` Andrew Morton
2011-10-31 13:21 ` [PATCH v2] " Michael Holzheu
2011-11-14 2:37 ` WANG Cong
2011-10-27 12:45 ` kdump: No udev events for memory hotplug? Dave Hansen
2011-10-27 13:18 ` Américo Wang
2011-10-27 7:45 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319842636.23600.186.camel@nimitz \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=kay.sievers@vrfy.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox