From: Markus Elfring <Markus.Elfring@web.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [v2] tools/bootconfig: fix resource leak in apply_xbc()
Date: Fri, 8 May 2020 12:17:44 +0200 [thread overview]
Message-ID: <131a5310-5d8e-5eb5-e55f-fa0a9a829ec1@web.de> (raw)
In-Reply-To: <20200508093059.GF9365@kadam>
> Btw, these leaks are totally harmless. This is a short running user
> space program with is going to immediately exit on error so the memory
> will be freed anyway.
Can such a view mean that the function call “free(data)” should be omitted here
for a quicker program termination?
> But the benifit is to silence static checker warnings so that's useful.
Would you like to extend the commit message for the explanation of
the importance of the proposed change accordingly?
Regards,
Markus
next prev parent reply other threads:[~2020-05-08 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:51 [PATCH v2] tools/bootconfig: fix resource leak in apply_xbc() Yunfeng Ye
2020-05-08 8:23 ` [PATCH v2] tools/bootconfig: Completion of error handling Markus Elfring
2020-05-08 9:30 ` [PATCH v2] tools/bootconfig: fix resource leak in apply_xbc() Dan Carpenter
2020-05-08 10:17 ` Markus Elfring [this message]
2020-05-08 10:32 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131a5310-5d8e-5eb5-e55f-fa0a9a829ec1@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox