From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753848Ab1JaGYi (ORCPT ); Mon, 31 Oct 2011 02:24:38 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:55419 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283Ab1JaGYh (ORCPT ); Mon, 31 Oct 2011 02:24:37 -0400 Message-ID: <1320042270.5683.3.camel@phoenix> Subject: [PATCH 2/2] mfd: tps6586x: Ensure setting bits if new value is different from the old value From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Mike Rapoport , Eric Miao , Samuel Ortiz Date: Mon, 31 Oct 2011 14:24:30 +0800 In-Reply-To: <1320042183.5683.1.camel@phoenix> References: <1320042183.5683.1.camel@phoenix> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.0- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It does not make sense to write new value only when all the bit_mask bits are zero. We need to write new value if the bit mask fields of new value is not equal to old value. Signed-off-by: Axel Lin --- drivers/mfd/tps6586x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index bba26d9..a5ddf31 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -197,7 +197,7 @@ int tps6586x_set_bits(struct device *dev, int reg, uint8_t bit_mask) if (ret) goto out; - if ((reg_val & bit_mask) == 0) { + if ((reg_val & bit_mask) != bit_mask) { reg_val |= bit_mask; ret = __tps6586x_write(to_i2c_client(dev), reg, reg_val); } -- 1.7.5.4