From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755421Ab1JaUsd (ORCPT ); Mon, 31 Oct 2011 16:48:33 -0400 Received: from exchange.solarflare.com ([216.237.3.220]:26106 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179Ab1JaUsc (ORCPT ); Mon, 31 Oct 2011 16:48:32 -0400 Subject: Re: [PATCH] bonding:update speed/duplex for NETDEV_CHANGE From: Ben Hutchings To: Jay Vosburgh CC: Weiping Pan , , , In-Reply-To: <14973.1320093129@death> References: <4EAE0D9A.9060408@gmail.com> <1320084906.2735.9.camel@bwh-desktop> <14973.1320093129@death> Content-Type: text/plain; charset="UTF-8" Organization: Solarflare Communications Date: Mon, 31 Oct 2011 20:48:28 +0000 Message-ID: <1320094108.2735.15.camel@bwh-desktop> MIME-Version: 1.0 X-Mailer: Evolution 2.32.2 (2.32.2-1.fc14) Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.20.137] X-TM-AS-Product-Ver: SMEX-8.0.0.1181-6.500.1024-18482.005 X-TM-AS-Result: No--15.032300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-OriginalArrivalTime: 31 Oct 2011 20:48:32.0207 (UTC) FILETIME=[7386A5F0:01CC980E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-10-31 at 13:32 -0700, Jay Vosburgh wrote: [...] > This particular case arises only during enslavement. The call > to bond_update_speed_duplex call has failed, but the device is marked by > bonding to be up. Bonding complains that the device isn't down, but it > cannot get speed and duplex, and therefore is assuming them to be > 100/Full. > > The catch is that this happens only for the ARP monitor, because > it initially presumes a slave to be up regardless of actual carrier > state (for historical reasons related to very old 10 or 10/100 drivers, > prior to the introduction of netif_carrier_*). Right, I gathered that. Is there any reason to use the ARP monitor when all slaves support link state notification? Maybe the bonding documentation should recommend miimon in section 7, not just in section 2. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.