From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 2/2] hwspinlock/u8500: include linux/module.h
Date: Sun, 06 Nov 2011 21:16:51 +0800 [thread overview]
Message-ID: <1320585411.18391.4.camel@phoenix> (raw)
In-Reply-To: <1320585256.18391.1.camel@phoenix>
Include module.h to fix below build error:
CC drivers/hwspinlock/u8500_hsem.o
drivers/hwspinlock/u8500_hsem.c:177: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/hwspinlock/u8500_hsem.c:194: error: expected declaration specifiers or '...' before string constant
drivers/hwspinlock/u8500_hsem.c:194: warning: data definition has no type or storage class
drivers/hwspinlock/u8500_hsem.c:194: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/hwspinlock/u8500_hsem.c:194: warning: function declaration isn't a prototype
drivers/hwspinlock/u8500_hsem.c:195: error: expected declaration specifiers or '...' before string constant
drivers/hwspinlock/u8500_hsem.c:195: warning: data definition has no type or storage class
drivers/hwspinlock/u8500_hsem.c:195: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/hwspinlock/u8500_hsem.c:195: warning: function declaration isn't a prototype
drivers/hwspinlock/u8500_hsem.c:196: error: expected declaration specifiers or '...' before string constant
drivers/hwspinlock/u8500_hsem.c:196: warning: data definition has no type or storage class
drivers/hwspinlock/u8500_hsem.c:196: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/hwspinlock/u8500_hsem.c:196: warning: function declaration isn't a prototype
make[2]: *** [drivers/hwspinlock/u8500_hsem.o] Error 1
make[1]: *** [drivers/hwspinlock] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
I got the build error on linux-next 20111104.
Axel
drivers/hwspinlock/u8500_hsem.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hwspinlock/u8500_hsem.c b/drivers/hwspinlock/u8500_hsem.c
index a120f14..86980fe 100644
--- a/drivers/hwspinlock/u8500_hsem.c
+++ b/drivers/hwspinlock/u8500_hsem.c
@@ -21,6 +21,7 @@
* General Public License for more details.
*/
+#include <linux/module.h>
#include <linux/delay.h>
#include <linux/io.h>
#include <linux/pm_runtime.h>
--
1.7.5.4
next prev parent reply other threads:[~2011-11-06 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 13:14 [PATCH 1/2] hwspinlock/u8500: fix build error due to undefined label Axel Lin
2011-11-06 13:16 ` Axel Lin [this message]
2011-11-07 8:08 ` [PATCH 2/2] hwspinlock/u8500: include linux/module.h Linus Walleij
2011-11-06 16:27 ` [PATCH 1/2] hwspinlock/u8500: fix build error due to undefined label Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320585411.18391.4.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox