From: Huang Ying <ying.huang@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
ying.huang@intel.com, linux-acpi@vger.kernel.org
Subject: [PATCH 2/9] ACPI, APEI, Remove table not found message
Date: Tue, 8 Nov 2011 10:39:27 +0800 [thread overview]
Message-ID: <1320719974-3598-3-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1320719974-3598-1-git-send-email-ying.huang@intel.com>
Because APEI tables are optional, these message may confuse users, for
example,
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/599715
Reported-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
drivers/acpi/apei/einj.c | 5 ++---
drivers/acpi/apei/erst.c | 5 ++---
drivers/acpi/apei/hest.c | 5 ++---
3 files changed, 6 insertions(+), 9 deletions(-)
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -466,10 +466,9 @@ static int __init einj_init(void)
status = acpi_get_table(ACPI_SIG_EINJ, 0,
(struct acpi_table_header **)&einj_tab);
- if (status == AE_NOT_FOUND) {
- pr_info(EINJ_PFX "Table is not found!\n");
+ if (status == AE_NOT_FOUND)
return -ENODEV;
- } else if (ACPI_FAILURE(status)) {
+ else if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
pr_err(EINJ_PFX "Failed to get table, %s\n", msg);
return -EINVAL;
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -1112,10 +1112,9 @@ static int __init erst_init(void)
status = acpi_get_table(ACPI_SIG_ERST, 0,
(struct acpi_table_header **)&erst_tab);
- if (status == AE_NOT_FOUND) {
- pr_info(ERST_PFX "Table is not found!\n");
+ if (status == AE_NOT_FOUND)
goto err;
- } else if (ACPI_FAILURE(status)) {
+ else if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
pr_err(ERST_PFX "Failed to get table, %s\n", msg);
rc = -EINVAL;
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -221,10 +221,9 @@ void __init acpi_hest_init(void)
status = acpi_get_table(ACPI_SIG_HEST, 0,
(struct acpi_table_header **)&hest_tab);
- if (status == AE_NOT_FOUND) {
- pr_info(HEST_PFX "Table not found.\n");
+ if (status == AE_NOT_FOUND)
goto err;
- } else if (ACPI_FAILURE(status)) {
+ else if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
pr_err(HEST_PFX "Failed to get table, %s\n", msg);
rc = -EINVAL;
next prev parent reply other threads:[~2011-11-08 2:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 2:39 [PATCH 0/8] ACPI, APEI patches for 3.2 (Resend) Huang Ying
2011-11-08 2:39 ` [PATCH 1/9] ACPI, APEI, Print resource errors in conventional format Huang Ying
2011-11-08 2:39 ` Huang Ying [this message]
2011-11-08 2:39 ` [PATCH 3/9] ACPI, Record ACPI NVS regions Huang Ying
2011-11-08 15:40 ` Bjorn Helgaas
2011-11-08 2:39 ` [PATCH 4/9] ACPI, APEI, Resolve false conflict between ACPI NVS and APEI Huang Ying
2011-11-18 1:41 ` Thomas Renninger
2011-11-08 2:39 ` [PATCH 5/9] ACPI, APEI, EINJ, Fix resource conflict on some machine Huang Ying
2011-11-08 2:39 ` [PATCH 6/9] ACPI, Add RAM mapping support to ACPI atomic IO support Huang Ying
2011-11-08 21:38 ` Myron Stowe
2012-01-17 9:51 ` Len Brown
2011-11-08 2:39 ` [PATCH 7/9] ACPI, APEI, EINJ, Refine the fix of resource conflict Huang Ying
2011-11-08 2:39 ` [PATCH 8/9] ACPI, APEI, GHES: Add PCIe AER recovery support Huang Ying
2011-11-08 2:39 ` [PATCH 9/9] ACPI, APEI, GHES, Distinguish interleaved error report in kernel log Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320719974-3598-3-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).