From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757543Ab1KJIje (ORCPT ); Thu, 10 Nov 2011 03:39:34 -0500 Received: from www17.your-server.de ([213.133.104.17]:57896 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752844Ab1KJIjc (ORCPT ); Thu, 10 Nov 2011 03:39:32 -0500 Message-ID: <1320914364.20155.10.camel@localhost.localdomain> Subject: Re: [PATCH] Hexagon: Use resource_size function From: Thomas Meyer To: David Brown Cc: Richard Kuo , Arnd Bergmann , linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 10 Nov 2011 09:39:24 +0100 In-Reply-To: <20111109010202.GA16505@huya.qualcomm.com> References: <1320778170.8062.134.camel@localhost.localdomain> <20111109010202.GA16505@huya.qualcomm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1 (3.2.1-2.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 08.11.2011, 17:02 -0800 schrieb David Brown: > Some minor nits about the formatting of the patch. > > On Tue, Nov 08, 2011 at 07:49:30PM +0100, Thomas Meyer wrote: > > From: Thomas Meyer > > Shouldn't need a From: line, since it is the same as the email you > sent it from. So do I need a From: line or not? Documentation/SubmittingPatches says: The "from" line must be the very first line in the message body, and has the form: From: Original Author The "from" line specifies who will be credited as the author of the patch in the permanent changelog. If the "from" line is missing, then the "From:" line from the email header will be used to determine the patch author in the changelog. MUST in the meaning of RFC2119, means it is an absolut requirment. What should I do? OTOH some people seems to ignore this, too: Do not send more than 15 patches at once to the vger mailing lists!!! > > > Use resource_size function on resource object > > instead of explicit computation. > > The commit text shouldn't be indented. Will fix that. > > > The semantic patch that makes this change is available > > in scripts/coccinelle/api/resource_size.cocci. > > > > More information about semantic patching is available at > > http://coccinelle.lip6.fr/ > > I'm curious if these patches are generated directly by coccinelle, > since they don't appear to be coming from git. It'd be nice to have > diffstats in them (especially when they are larger). coccinelle doesn't work that way. It's independent from git. I need to check the manual of spatch.bin if it's possible to produce a diffstat. > Thanks, > David >