Re: [PATCH 3.1-stable] staging: brcm80211: fix for rate index in receive status

Greg KH
2011-11-10T18:45:55Z

On Thu, Nov 10, 2011 at 07:37:10PM +0100, Arend van Spriel wrote:
> On 11/10/2011 04:17 PM, Greg KH wrote:
> > On Thu, Nov 10, 2011 at 10:48:34AM +0100, Arend van Spriel wrote:
> >> This fix resolves an issue on 5GHz as posted on LKML:
> >>
> >> BUG: All network processes hang (brcmsmac/wpa_supplicant)
> >> ID: <20111018111422.GA1979@schottelius.org>
> >
> > What are these tags for? I've not seen them in kernel patches before.
> >
>
> The first line was the email Subject as posted on LKML. The second is
> the message id.

Neither of those are something we normally put in changelog comments,
right?

> >> Cc: stable@kernel.org
> >
> > Wrong address, please use stable@vger.kernel.org now.
> >
>
> Noted.
>
> >> Reported-by: Nico Schottelius <nico-linux-20111017@schottelius.org>
> >> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> >> ---
> >> Hi Greg,
> >>
> >> This change is in the mainline brcmsmac driver, but I do not have a commit
> >> message to refer to as we transitioned from staging to mainline in the last
> >> merge window. Can you process this patch without that info?
> >
> > No, I need the git commit id of the patch that fixed this in Linus's
> > tree, if the files are different due to the move, that's fine, but I
> > still need this to reference.
> >
>
> Here it is:
>
> commit 5a84d6ad4c9306afb467a600a4c6d7b50da49440
> Author: Arend van Spriel <arend@broadcom.com>
> Date: Tue Aug 23 14:14:00 2011 +0200
>
> staging: brcm80211: fill in proper rx rate in mac80211 rx status
>
> The brcmsmac driver supports different rates on 5GHz but this is not
> taken into account when providing the rate index in the receive
> status information passed to mac80211.
>
> Reviewed-by: Roland Vossen <rvossen@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
> Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Thanks, that's what I need. I'll queue this up for the next 3.1 kernel
after this one gets out later this week.

greg k-h