From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325Ab1KLM3a (ORCPT ); Sat, 12 Nov 2011 07:29:30 -0500 Received: from www17.your-server.de ([213.133.104.17]:50456 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648Ab1KLM33 (ORCPT ); Sat, 12 Nov 2011 07:29:29 -0500 Message-ID: <1321098984.1668.12.camel@localhost.localdomain> Subject: [PATCH] qnx4fs: Use kmemdup rather than duplicating its implementation From: Thomas Meyer To: Anders Larsen , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Date: Sat, 12 Nov 2011 12:56:24 +0100 Mime-Version: 1.0 X-Mailer: Evolution 3.2.1 (3.2.1-2.fc16) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use kmemdup rather than duplicating its implementation The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/qnx4/inode.c b/fs/qnx4/inode.c --- a/fs/qnx4/inode.c 2011-11-07 19:38:23.987165894 +0100 +++ b/fs/qnx4/inode.c 2011-11-08 10:33:59.882543999 +0100 @@ -199,12 +199,13 @@ static const char *qnx4_checkroot(struct if (!strcmp(rootdir->di_fname, QNX4_BMNAME)) { found = 1; - qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); + qnx4_sb(sb)->BitMap = kmemdup(rootdir, + sizeof(struct qnx4_inode_entry), + GFP_KERNEL); if (!qnx4_sb(sb)->BitMap) { brelse (bh); return "not enough memory for bitmap inode"; - } - memcpy( qnx4_sb(sb)->BitMap, rootdir, sizeof( struct qnx4_inode_entry ) ); /* keep bitmap inode known */ + }/* keep bitmap inode known */ break; } }