Re: [PATCH 1/2] v3.2-rc1-52e4c2a05-rt1 fix for compile break

Paul E. McKenney
2011-11-14T17:04:27Z

On Mon, Nov 14, 2011 at 02:44:42AM +0100, John Kacur wrote:
> kernel/rcutorture.c:492: error: ‘synchronize_rcu_bh’ undeclared here (not in a function)
>
> In CONFIG_PREEMPT_RT_FULL
> doesn't cover function pointer assignment unless we remove the brackets.
>
> Compile-tested.

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

I have not yet queued this because mainline does not yet fold RCU and
RCU-bh together.

Thanx, Paul

> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
> include/linux/rcutree.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/rcutree.h b/include/linux/rcutree.h
> index 800b840..6e503a3 100644
> --- a/include/linux/rcutree.h
> +++ b/include/linux/rcutree.h
> @@ -60,7 +60,7 @@ static inline void exit_rcu(void)
> #ifndef CONFIG_PREEMPT_RT_FULL
> extern void synchronize_rcu_bh(void);
> #else
> -# define synchronize_rcu_bh() synchronize_rcu()
> +# define synchronize_rcu_bh synchronize_rcu
> #endif
> extern void synchronize_sched_expedited(void);
> extern void synchronize_rcu_expedited(void);
> --
> 1.7.2.3
>