Re: [PATCH] printk: add console output tracing

Frederic Weisbecker
2011-11-17T14:55:16Z

On Wed, Nov 16, 2011 at 10:25:19PM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Add a printk.console trace point to record any printk
> messages into the trace, regardless of the current
> console loglevel. This can help correlate (existing)
> printk debugging with other tracing.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> include/trace/events/printk.h | 44 ++++++++++++++++++++++++++++++++++++++++++
> kernel/printk.c | 3 ++
> kernel/trace/Makefile | 1
> kernel/trace/printk-trace.c | 14 +++++++++++++
> 4 files changed, 62 insertions(+)
<snip>
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ b/kernel/trace/printk-trace.c 2011-11-16 21:22:20.000000000 +0100
> @@ -0,0 +1,14 @@
> +/*
> + * printk trace points
> + *
> + * Copyright (C) 2011 Johannes Berg <johannes.berg@intel.com>
> + */
> +
> +#include <linux/string.h>
> +#include <linux/types.h>
> +#include <linux/workqueue.h>
> +#include <linux/sched.h>
> +#include <linux/module.h>
> +
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/printk.h>

Why not defining the tracepoint in kernel/printk.c ?