Re: [PATCH v2] printk: add console output tracing

Johannes Berg
2011-11-24T13:22:07Z

On Wed, 2011-11-23 at 14:16 +0100, Frederic Weisbecker wrote:

> > Also, call_console_drivers() doesn't pass this start/end through to
> > _call_console_drivers(), it has loops and stuff there...
>
> Yeah but looking at the loop there, start and end passed to
> __call_console_drivers() are bounded between start and end passed to
> call_console_drivers().

Looks like. Not that I have any idea why other code handles the wrap
then?

> > In any case -- feel free to clean it all up, I basically copied the
> > logic from _call_console_drivers assuming it was needed.
>
> I'm just reviewing and suggesting a way to keep the patch more simple.
> Outside that, I don't really need that patch myself ;)

:-)

> > I don't really want to know about the printk details :-)
>
> Well, it's like working out outside in winter. It may not sound
> very entertaining in the beginning but then it quickly becomes
> invigorating, toning and good for the mood...I think...

Heh....

I don't really feel comfortable modifying the _call_console_drivers()
function to not handle start > end (modulo log buf size of course), but
at the same time I don't feel comfortable putting code into it that
doesn't handle it.

johannes