From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: [PATCH] printk: add console output tracing
Date: Wed, 16 Nov 2011 22:25:19 +0100 [thread overview]
Message-ID: <1321478719.4502.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1321473443.4181.38.camel@frodo>
From: Johannes Berg <johannes.berg@intel.com>
Add a printk.console trace point to record any printk
messages into the trace, regardless of the current
console loglevel. This can help correlate (existing)
printk debugging with other tracing.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
include/trace/events/printk.h | 44 ++++++++++++++++++++++++++++++++++++++++++
kernel/printk.c | 3 ++
kernel/trace/Makefile | 1
kernel/trace/printk-trace.c | 14 +++++++++++++
4 files changed, 62 insertions(+)
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ b/include/trace/events/printk.h 2011-11-16 22:06:43.000000000 +0100
@@ -0,0 +1,44 @@
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM printk
+
+#if !defined(_TRACE_PRINTK_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_PRINTK_H
+
+#include <linux/tracepoint.h>
+
+TRACE_EVENT_CONDITION(console,
+ TP_PROTO(const char *log_buf, unsigned start, unsigned end,
+ unsigned log_buf_len),
+
+ TP_ARGS(log_buf, start, end, log_buf_len),
+
+ TP_CONDITION(start != end),
+
+ TP_STRUCT__entry(
+ __dynamic_array(char, msg,
+ ((end - start + log_buf_len) &
+ (log_buf_len - 1)) + 1)
+ ),
+
+ TP_fast_assign(
+ if ((start & (log_buf_len - 1)) > (end & (log_buf_len - 1))) {
+ memcpy(__get_dynamic_array(msg),
+ log_buf + (start & (log_buf_len - 1)),
+ log_buf_len - (start & (log_buf_len - 1)));
+ memcpy((char *)__get_dynamic_array(msg) +
+ log_buf_len - (start & (log_buf_len - 1)),
+ log_buf, end & (log_buf_len - 1));
+ } else
+ memcpy(__get_dynamic_array(msg),
+ log_buf + (start & (log_buf_len - 1)),
+ (end - start + log_buf_len) & (log_buf_len - 1));
+ ((char *)__get_dynamic_array(msg))[(end - start + log_buf_len) &
+ (log_buf_len - 1)] = 0;
+ ),
+
+ TP_printk("%s", __get_str(msg))
+);
+#endif /* _TRACE_PRINTK_H */
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>
--- a/kernel/printk.c 2011-11-16 16:37:20.000000000 +0100
+++ b/kernel/printk.c 2011-11-16 21:47:20.000000000 +0100
@@ -41,6 +41,7 @@
#include <linux/cpu.h>
#include <linux/notifier.h>
#include <linux/rculist.h>
+#include <trace/events/printk.h>
#include <asm/uaccess.h>
@@ -542,6 +543,8 @@ MODULE_PARM_DESC(ignore_loglevel, "ignor
static void _call_console_drivers(unsigned start,
unsigned end, int msg_log_level)
{
+ trace_console(&LOG_BUF(0), start, end, log_buf_len);
+
if ((msg_log_level < console_loglevel || ignore_loglevel) &&
console_drivers && start != end) {
if ((start & LOG_BUF_MASK) > (end & LOG_BUF_MASK)) {
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ b/kernel/trace/printk-trace.c 2011-11-16 21:22:20.000000000 +0100
@@ -0,0 +1,14 @@
+/*
+ * printk trace points
+ *
+ * Copyright (C) 2011 Johannes Berg <johannes.berg@intel.com>
+ */
+
+#include <linux/string.h>
+#include <linux/types.h>
+#include <linux/workqueue.h>
+#include <linux/sched.h>
+#include <linux/module.h>
+
+#define CREATE_TRACE_POINTS
+#include <trace/events/printk.h>
--- a/kernel/trace/Makefile 2011-11-16 16:37:20.000000000 +0100
+++ b/kernel/trace/Makefile 2011-11-16 21:38:49.000000000 +0100
@@ -55,6 +55,7 @@ endif
obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o
obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o
obj-$(CONFIG_TRACEPOINTS) += power-traces.o
+obj-$(CONFIG_TRACEPOINTS) += printk-trace.o
ifeq ($(CONFIG_PM_RUNTIME),y)
obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o
endif
next prev parent reply other threads:[~2011-11-16 21:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 10:18 [PATCH] tracing: add trace console Johannes Berg
2011-11-16 14:15 ` Steven Rostedt
2011-11-16 14:25 ` Peter Zijlstra
2011-11-16 14:30 ` Johannes Berg
2011-11-16 14:41 ` Peter Zijlstra
2011-11-16 14:48 ` Steven Rostedt
2011-11-16 14:50 ` Peter Zijlstra
2011-11-16 14:51 ` Johannes Berg
2011-11-16 15:17 ` Steven Rostedt
2011-11-16 14:32 ` Thomas Gleixner
2011-11-16 14:35 ` Frederic Weisbecker
2011-11-16 15:09 ` [PATCH v2] " Johannes Berg
2011-11-16 15:17 ` Peter Zijlstra
2011-11-16 15:19 ` Steven Rostedt
2011-11-16 15:10 ` [PATCH] " Christoph Hellwig
2011-11-16 15:17 ` Johannes Berg
2011-11-16 16:41 ` Steven Rostedt
2011-11-16 16:45 ` Johannes Berg
2011-11-16 17:00 ` Steven Rostedt
2011-11-16 17:05 ` Steven Rostedt
2011-11-16 18:33 ` Johannes Berg
2011-11-16 19:57 ` Steven Rostedt
2011-11-16 20:12 ` Johannes Berg
2011-11-16 21:25 ` Johannes Berg [this message]
2011-11-17 1:01 ` [PATCH] printk: add console output tracing Steven Rostedt
2011-11-17 14:55 ` Frederic Weisbecker
2011-11-17 14:57 ` Johannes Berg
2011-11-17 15:00 ` Frederic Weisbecker
2011-11-17 15:17 ` Steven Rostedt
2011-11-17 15:21 ` [PATCH v2] " Johannes Berg
2011-11-18 18:44 ` Frederic Weisbecker
2011-11-18 18:46 ` Johannes Berg
2011-11-18 18:54 ` Frederic Weisbecker
2011-11-18 18:59 ` Johannes Berg
2011-11-23 13:16 ` Frederic Weisbecker
2011-11-24 13:21 ` Johannes Berg
2011-11-24 15:45 ` Frederic Weisbecker
2011-11-24 19:00 ` Johannes Berg
2011-11-25 17:43 ` Frederic Weisbecker
2011-11-25 18:11 ` Johannes Berg
2011-11-24 19:03 ` [PATCH v3] " Johannes Berg
2011-11-25 17:41 ` Frederic Weisbecker
2011-12-02 18:05 ` Steven Rostedt
2012-02-13 17:30 ` Steven Rostedt
2012-02-13 17:33 ` Johannes Berg
2012-02-13 17:42 ` Steven Rostedt
2012-02-17 13:52 ` [tip:perf/core] printk/tracing: Add " tip-bot for Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321478719.4502.20.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox