From: Peter Zijlstra <peterz@infradead.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Ingo Molnar <mingo@redhat.com>,
Nick Bowler <nbowler@elliptictech.com>, Greg KH <greg@kroah.com>,
Dave Jones <davej@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Randy Dunlap <rdunlap@xenotime.net>,
LKML <linux-kernel@vger.kernel.org>,
Debian kernel maintainers <debian-kernel@lists.debian.org>
Subject: Re: [PATCH 1/2] lockdep,rtmutex,bug: Show taint flags on error
Date: Thu, 17 Nov 2011 09:48:29 +0100 [thread overview]
Message-ID: <1321519709.27735.13.camel@twins> (raw)
In-Reply-To: <20111116215236.GD3366@decadent.org.uk>
On Wed, 2011-11-16 at 21:52 +0000, Ben Hutchings wrote:
> On Fri, Oct 28, 2011 at 04:36:55AM +0100, Ben Hutchings wrote:
> > Currently lock debugging is disabled when the kernel is tainted, with
> > a few exceptions. It is already recognised that this can be useful
> > for staging modules (TAINT_CRAP), but that also goes for out-of-tree
> > modules (TAINT_OOT_MODULE) so long as core kernel developers don't
> > have to spend time debugging them. Also, there are several reasons
> > for tainting that are unlikely to introduce false locking bug reports
> > (e.g. TAINT_FIRMWARE_WORKAROUND).
> > Instead of disabling lock debugging, show the taint flags in all
> > lockdep and rtmutex-debug error messages.
So this is two patches in one. I took the last part, the printing of the
taint flags thing, not the first part.
I did a small patch adding TAINT_FIRMWARE_WORKAROUND to the list of
TAINTS that shouldn't disable lockdep.
As for OOT_MODULE, with staging the only reason not to merge a module is
it being the wrong license and I really can't be arsed about OOT stuff
anyway, so no.
next prev parent reply other threads:[~2011-11-17 8:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 3:36 [PATCH 1/2] lockdep,rtmutex,bug: Show taint flags on error Ben Hutchings
2011-10-31 1:59 ` Rusty Russell
2011-11-16 21:52 ` Ben Hutchings
2011-11-16 22:24 ` Dave Jones
2011-11-17 8:48 ` Peter Zijlstra [this message]
2011-11-17 15:18 ` Ben Hutchings
2011-12-06 9:38 ` [tip:core/locking] lockdep, rtmutex, bug: " tip-bot for Ben Hutchings
2011-12-06 15:34 ` Ben Hutchings
2011-12-06 17:48 ` Peter Zijlstra
2011-12-06 17:55 ` Alan Cox
2011-12-06 17:56 ` Peter Zijlstra
2011-12-06 17:59 ` Ingo Molnar
2011-12-06 18:17 ` Ben Hutchings
2011-12-06 18:28 ` Ingo Molnar
2011-12-06 19:14 ` Ingo Molnar
2011-12-06 21:13 ` Ben Hutchings
2011-12-07 7:49 ` Ingo Molnar
2011-12-06 18:04 ` Ingo Molnar
2011-12-06 17:54 ` Ingo Molnar
2011-12-06 18:14 ` Nick Bowler
2011-12-06 18:20 ` Ingo Molnar
2011-12-06 18:21 ` Alan Cox
2011-12-06 18:34 ` Ingo Molnar
2011-12-06 18:23 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321519709.27735.13.camel@twins \
--to=peterz@infradead.org \
--cc=ben@decadent.org.uk \
--cc=davej@redhat.com \
--cc=debian-kernel@lists.debian.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nbowler@elliptictech.com \
--cc=rdunlap@xenotime.net \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox