From: David Daney <ddaney.cavm@gmail.com>
To: linux-mips@linux-mips.org, ralf@linux-mips.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: David Daney <david.daney@cavium.com>,
David Rientjes <rientjes@google.com>
Subject: [PATCH v2 1/2] hugetlb: Provide a default HPAGE_SHIFT if !CONFIG_HUGETLB_PAGE
Date: Thu, 17 Nov 2011 13:57:29 -0800 [thread overview]
Message-ID: <1321567050-13197-2-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1321567050-13197-1-git-send-email-ddaney.cavm@gmail.com>
From: David Daney <david.daney@cavium.com>
When linux-next 10111117 is build for MIPS with
cavium-octeon_defconfig, we get:
arch/mips/mm/tlb-r4k.c: In function 'local_flush_tlb_range':
arch/mips/mm/tlb-r4k.c:129:28: error: 'HPAGE_SHIFT' undeclared (first use in this function)
The fix is to supply a dummy HPAGE_SHIFT in the !CONFIG_HUGETLB_PAGE
case. Instead of supplying the non-huge value, as was done for
HPAGE_MASK and HPAGE_SIZE, we do BUG() instead. This satisfies the
compiler, but give us runtime safety if someone were to use HPAGE_SIZE
incorrectly.
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: David Daney <david.daney@cavium.com>
---
include/linux/hugetlb.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 19644e0..380451c 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -113,6 +113,7 @@ static inline void copy_huge_page(struct page *dst, struct page *src)
#ifndef HPAGE_MASK
#define HPAGE_MASK PAGE_MASK /* Keep the compiler happy */
#define HPAGE_SIZE PAGE_SIZE
+#define HPAGE_SHIFT ({BUG(); 0; })
#endif
#endif /* !CONFIG_HUGETLB_PAGE */
--
1.7.2.3
next prev parent reply other threads:[~2011-11-17 21:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 21:57 [PATCH v2 0/2] Dummy HPAGE_* constants for !CONFIG_HUGETLB_PAGE David Daney
2011-11-17 21:57 ` David Daney [this message]
2011-11-17 21:57 ` [PATCH v2 2/2] hugetlb: Provide safer dummy values for HPAGE_MASK and HPAGE_SIZE David Daney
2011-11-17 23:28 ` Andrew Morton
2011-11-17 23:38 ` David Daney
2011-11-18 8:56 ` Sergei Shtylyov
2011-11-18 17:14 ` David Daney
2011-11-17 23:22 ` [PATCH v2 0/2] Dummy HPAGE_* constants for !CONFIG_HUGETLB_PAGE David Rientjes
2011-11-17 23:22 ` [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE David Rientjes
2011-11-17 23:35 ` Andrew Morton
2011-11-17 23:44 ` David Rientjes
2011-11-17 23:52 ` David Daney
2011-11-17 23:57 ` Andrew Morton
2011-11-17 23:57 ` David Rientjes
2011-11-21 22:23 ` David Daney
2011-11-21 22:43 ` Linus Torvalds
2011-11-21 23:23 ` David Daney
2011-11-21 23:43 ` Linus Torvalds
2011-11-21 23:50 ` Andrew Morton
2011-11-22 20:41 ` Andi Kleen
2011-11-21 23:47 ` David Daney
2011-11-21 23:53 ` Andrew Morton
2011-11-22 0:37 ` Linus Torvalds
2011-11-22 0:48 ` David Daney
2011-11-22 0:55 ` Linus Torvalds
2011-11-21 22:48 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321567050-13197-2-git-send-email-ddaney.cavm@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).